fix: Please provide binary data as `Uint8Array`, rather than `Buffer`. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

acdzh wants to merge 1 commit into sylphxltd:main from acdzh:main

acdzh commented Sep 25, 2025

https://github.com/mozilla/pdf.js/blob/45cbe8bb0dc4c1c16ca8ec404463dd0f4d79ce6d/src/display/api.js#L236

this function needs an ArrayBuffer insteads of BufferLike.

if using Buffer, it will broken

https://github.com/mozilla/pdf.js/blob/45cbe8bb0dc4c1c16ca8ec404463dd0f4d79ce6d/src/display/api.js#L568C6-L568C74


          fix: Please provide binary data as Uint8Array, rather than Buffer.

94f7943

Author

acdzh commented Sep 25, 2025

gkzhb commented Oct 11, 2025

There is a typo in PR, see b55766b for the fix(from my fork branch https://github.com/gkzhb/pdf-reader-mcp/tree/fix/ts-error).

The fix is published as @gkzhb/pdf-reader-mcp npm package @gkzhb/pdf-reader-mcp - npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet