At vars #266
Closed
At vars #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
don't know why |
Contributor
Author
|
Was there something holding this back? |
isuruf
reviewed
Sep 9, 2024
Comment on lines
+1
to
+4
| # !!! Note: | ||
| # Many thanks to `@matthieubulte` for this contribution to `SymPy`. | ||
|
|
||
| # The map_subscripts function is stolen from Symbolics.jl |
Member
There was a problem hiding this comment.
What are the licenses for these codes?
Contributor
Author
There was a problem hiding this comment.
Good question, MIT (https://github.com/JuliaPy/SymPy.jl/blob/master/LICENSE.md)
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
ping. Any comment on merging this? |
Member
|
Looks good . Feel free to merge when CI pass |
Contributor
Author
|
I can't tell why the lcm test is failing here. The substantial change here is the extension to the at vars macro. Let me work that into a separate PR to see if that cleanly passes CI. |
Contributor
Author
|
I should close this in lieu of #278 |
Contributor
Author
|
Closed with #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few things:
@symsfromSymPyto enhance@vars(allowing for arrays of variables and symbolic functions to be more easily created)SymEngine.jlmathfuns.jl@varsusageSorry, I see the PR #265 is also included here. If that is not desired, I can rework.)