Merge pull request #413 from symflower/go-1.23.6

zimmski · web-flow · commit eb7086b918a3 · 2025-02-09T16:25:34.000+01:00
Upgrade Go to 1.23.6 (from 1.21.5)
diff --git a/.github/workflows/job-lint.yml b/.github/workflows/job-lint.yml
@@ -11,7 +11,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: "1.23.6"
 
       - name: Install ack
         run: sudo apt-get update && sudo apt-get install -y ack-grep
diff --git a/.github/workflows/job-test.yml b/.github/workflows/job-test.yml
@@ -21,23 +21,23 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
+          go-version: "1.23.6"
 
       - name: Set up Java
         uses: actions/setup-java@v4
         with:
-          distribution: 'corretto'
-          java-version: '11'
+          distribution: "corretto"
+          java-version: "11"
 
       - name: Set up Maven
         uses: stCarolas/setup-maven@v5
         with:
-          maven-version: '3.9.1'
+          maven-version: "3.9.1"
 
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3.4'
+          ruby-version: "3.3.4"
 
       - name: Set up Git
         run: |
diff --git a/Dockerfile b/Dockerfile
@@ -64,9 +64,9 @@ ENV JAVA_HOME="/app/.eval-dev-quality/amazon-corretto-11.0.24.8.1-linux-x64"
 ENV PATH="${PATH}:${JAVA_HOME}/bin"
 
 # Install Go
-RUN wget https://go.dev/dl/go1.21.5.linux-amd64.tar.gz && \
-	tar -xf go1.21.5.linux-amd64.tar.gz -C /app/.eval-dev-quality/ && \
-	rm go1.21.5.linux-amd64.tar.gz
+RUN wget https://go.dev/dl/go1.23.6.linux-amd64.tar.gz && \
+	tar -xf go1.23.6.linux-amd64.tar.gz -C /app/.eval-dev-quality/ && \
+	rm go1.23.6.linux-amd64.tar.gz
 ENV PATH="${PATH}:/app/.eval-dev-quality/go/bin"
 ENV GOROOT="/app/.eval-dev-quality/go"
 ENV PATH="${PATH}:/home/ubuntu/go/bin"
diff --git a/Makefile b/Makefile
@@ -57,7 +57,7 @@ install-tools: # Install tools that are required for running the evaluation.
 install-tools-linting: # Install tools that are used for linting.
 	go install -v github.com/kisielk/errcheck@v1.7.0
 	go install -v github.com/mgechev/revive@v1.4.0
-	go install -v golang.org/x/tools/cmd/deadcode@v0.16.1
+	go install -v golang.org/x/tools/cmd/deadcode@v0.27.1-0.20241219162658-575221bfbda3 # Aligned with version `gopls/v0.17.1`.
 	go install -v honnef.co/go/tools/cmd/staticcheck@2024.1.1
 .PHONY: install-tools-linting
 
diff --git a/cmd/eval-dev-quality/cmd/evaluate.go b/cmd/eval-dev-quality/cmd/evaluate.go
@@ -629,7 +629,10 @@ func (command *Evaluate) evaluateDocker(ctx *evaluate.Context) (err error) {
 			Command: cmd,
 		})
 		if err != nil {
-			ctx.Log.Error("ERROR: Unable to pull image", pkgerrors.WithMessage(pkgerrors.WithStack(err), commandOutput))
+			ctx.Log.Error(
+				"ERROR: unable to pull image",
+				"error", pkgerrors.WithMessage(pkgerrors.WithStack(err), commandOutput),
+			)
 		}
 	}
 
diff --git a/evaluate/task/symflower.go b/evaluate/task/symflower.go
@@ -59,7 +59,7 @@ func symflowerTemplate(logger *log.Logger, repositoryPath string, language langu
 // ExecuteWithSymflowerFix runs the "symflower fix" command and calculates the new assessments.
 func ExecuteWithSymflowerFix(ctx evaltask.Context, logger *log.Logger, packagePath string) (testResult *language.TestResult, processingTime uint64, problems []error, err error) {
 	// Run "symflower fix"  if the model response fails to execute.
-	logger.Info("model response alone failed execution, attempting to fix with \"symflower fix \"")
+	logger.Info("model response alone failed execution, attempting to fix with \"symflower fix\"")
 
 	duration, err := symflowerFix(logger, packagePath, ctx.Language)
 	if err != nil {
diff --git a/evaluate/task/write-test_test.go b/evaluate/task/write-test_test.go
@@ -44,7 +44,7 @@ func TestWriteTestsRun(t *testing.T) {
 
 		repositoryPath := filepath.Join(temporaryDirectoryPath, "golang", "plain")
 		require.NoError(t, os.MkdirAll(repositoryPath, 0700))
-		require.NoError(t, os.WriteFile(filepath.Join(repositoryPath, "go.mod"), []byte("module plain\n\ngo 1.21.5"), 0600))
+		require.NoError(t, os.WriteFile(filepath.Join(repositoryPath, "go.mod"), []byte("module plain\n\ngo 1.23.6"), 0600))
 		require.NoError(t, os.WriteFile(filepath.Join(repositoryPath, "caseA.go"), []byte("package plain\n\nfunc caseA(){}"), 0600))
 		require.NoError(t, os.WriteFile(filepath.Join(repositoryPath, "caseB.go"), []byte("package plain\n\nfunc caseB(){}"), 0600))
 
diff --git a/go.mod b/go.mod
@@ -1,36 +1,39 @@
 module github.com/symflower/eval-dev-quality
 
-go 1.21.5
+go 1.23.6
 
 require (
 	github.com/avast/retry-go v3.0.0+incompatible
 	github.com/jessevdk/go-flags v1.5.1-0.20210607101731-3927b71304df
 	github.com/kr/pretty v0.3.1
 	github.com/pkg/errors v0.9.1
 	github.com/sashabaranov/go-openai v1.36.2-0.20250131190529-45aa99607be0
-	github.com/stretchr/testify v1.9.0
+	github.com/stretchr/testify v1.10.0
 	github.com/symflower/lockfile v0.0.0-20240419143922-aa3b60940c84
-	github.com/zimmski/osutil v1.3.0
-	golang.org/x/exp v0.0.0-20240325151524-a685a6edb6d8
-	golang.org/x/mod v0.16.0
+	github.com/zimmski/osutil v1.4.0
+	golang.org/x/exp v0.0.0-20250207012021-f9890c6ad9f3
+	golang.org/x/mod v0.23.0
 	gonum.org/v1/gonum v0.15.0 // WORKAROUND v0.15.1 is only supported for Go 1.22+ so explicitly use v0.15.0 to stick with our older Go version.
 )
 
 require (
-	github.com/Masterminds/semver/v3 v3.3.1 // indirect
+	github.com/Masterminds/semver/v3 v3.3.1
+	github.com/google/uuid v1.6.0
+)
+
+require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/google/uuid v1.6.0 // indirect
 	github.com/kr/text v0.2.0 // indirect
 	github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/rogpeppe/go-internal v1.9.0 // indirect
-	github.com/schollz/progressbar/v3 v3.14.2 // indirect
+	github.com/schollz/progressbar/v3 v3.18.0 // indirect
 	github.com/stretchr/objx v0.5.2 // indirect
 	github.com/termie/go-shutil v0.0.0-20140729215957-bcacb06fecae // indirect
-	github.com/ulikunitz/xz v0.5.11 // indirect
+	github.com/ulikunitz/xz v0.5.12 // indirect
 	github.com/yuin/goldmark v1.7.0 // indirect
-	golang.org/x/sys v0.18.0 // indirect
-	golang.org/x/term v0.18.0 // indirect
+	golang.org/x/sys v0.30.0 // indirect
+	golang.org/x/term v0.29.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
diff --git a/go.sum b/go.sum
@@ -27,42 +27,54 @@ github.com/rivo/uniseg v0.4.7 h1:WUdvkW8uEhrYfLC4ZzdpI2ztxP1I582+49Oc5Mq64VQ=
 github.com/rivo/uniseg v0.4.7/go.mod h1:FN3SvrM+Zdj16jyLfmOkMNblXMcoc8DfTHruCPUcx88=
 github.com/rogpeppe/go-internal v1.9.0 h1:73kH8U+JUqXU8lRuOHeVHaa/SZPifC7BkcraZVejAe8=
 github.com/rogpeppe/go-internal v1.9.0/go.mod h1:WtVeX8xhTBvf0smdhujwtBcq4Qrzq/fJaraNFVN+nFs=
-github.com/sashabaranov/go-openai v1.20.4 h1:095xQ/fAtRa0+Rj21sezVJABgKfGPNbyx/sAN/hJUmg=
-github.com/sashabaranov/go-openai v1.20.4/go.mod h1:lj5b/K+zjTSFxVLijLSTDZuP7adOgerWeFyZLUhAKRg=
 github.com/sashabaranov/go-openai v1.36.2-0.20250131190529-45aa99607be0 h1:WlepprDHs6tUt2/ihnvTL7DvXpO6IOllVP+oPWn2U0k=
 github.com/sashabaranov/go-openai v1.36.2-0.20250131190529-45aa99607be0/go.mod h1:lj5b/K+zjTSFxVLijLSTDZuP7adOgerWeFyZLUhAKRg=
 github.com/schollz/progressbar/v3 v3.14.2 h1:EducH6uNLIWsr560zSV1KrTeUb/wZGAHqyMFIEa99ks=
 github.com/schollz/progressbar/v3 v3.14.2/go.mod h1:aQAZQnhF4JGFtRJiw/eobaXpsqpVQAftEQ+hLGXaRc4=
+github.com/schollz/progressbar/v3 v3.18.0 h1:uXdoHABRFmNIjUfte/Ex7WtuyVslrw2wVPQmCN62HpA=
+github.com/schollz/progressbar/v3 v3.18.0/go.mod h1:IsO3lpbaGuzh8zIMzgY3+J8l4C8GjO0Y9S69eFvNsec=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/objx v0.5.2 h1:xuMeJ0Sdp5ZMRXx/aWO6RZxdr3beISkG5/G/aIRr3pY=
 github.com/stretchr/objx v0.5.2/go.mod h1:FRsXN1f5AsAjCGJKqEizvkpNtU+EGNCLh3NxZ/8L+MA=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
 github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
+github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
+github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
 github.com/symflower/lockfile v0.0.0-20240419143922-aa3b60940c84 h1:yhPz6r3LLBDjoV0rIDUlyuvWQg9L4MTfdksLVX6/q0s=
 github.com/symflower/lockfile v0.0.0-20240419143922-aa3b60940c84/go.mod h1:W/87GmsQmvlsvcXeuAlTGjIpTHrTTHDEIVH936LjnqI=
 github.com/termie/go-shutil v0.0.0-20140729215957-bcacb06fecae h1:vgGSvdW5Lqg+I1aZOlG32uyE6xHpLdKhZzcTEktz5wM=
 github.com/termie/go-shutil v0.0.0-20140729215957-bcacb06fecae/go.mod h1:quDq6Se6jlGwiIKia/itDZxqC5rj6/8OdFyMMAwTxCs=
 github.com/ulikunitz/xz v0.5.11 h1:kpFauv27b6ynzBNT/Xy+1k+fK4WswhN/6PN5WhFAGw8=
 github.com/ulikunitz/xz v0.5.11/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
+github.com/ulikunitz/xz v0.5.12 h1:37Nm15o69RwBkXM0J6A5OlE67RZTfzUxTj8fB3dfcsc=
+github.com/ulikunitz/xz v0.5.12/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
 github.com/yuin/goldmark v1.7.0 h1:EfOIvIMZIzHdB/R/zVrikYLPPwJlfMcNczJFMs1m6sA=
 github.com/yuin/goldmark v1.7.0/go.mod h1:uzxRWxtg69N339t3louHJ7+O03ezfj6PlliRlaOzY1E=
-github.com/zimmski/osutil v1.2.0 h1:M0Xau+QdEIN0urgr7RZUqgs5dxsT1pDJ3/mDqd7uexk=
-github.com/zimmski/osutil v1.2.0/go.mod h1:TZrA1ZvRIeylQ0ECaANmCVlT0WR/62zJxMdQX9SyLvY=
 github.com/zimmski/osutil v1.3.0 h1:433lf7bULKaZGBVtBI0j0Nt6t9mveo0vXEnTpD7jidw=
 github.com/zimmski/osutil v1.3.0/go.mod h1:TZrA1ZvRIeylQ0ECaANmCVlT0WR/62zJxMdQX9SyLvY=
+github.com/zimmski/osutil v1.4.0 h1:tEFk3Q5A9h3xi5XglgZ7GN+tpk7bgd8KUlWD5ki2V4E=
+github.com/zimmski/osutil v1.4.0/go.mod h1:e19OGVlot2UkwWHwcOFu5FeSNF3/TLMNeGcZcCy5UDg=
 golang.org/x/exp v0.0.0-20240325151524-a685a6edb6d8 h1:aAcj0Da7eBAtrTp03QXWvm88pSyOt+UgdZw2BFZ+lEw=
 golang.org/x/exp v0.0.0-20240325151524-a685a6edb6d8/go.mod h1:CQ1k9gNrJ50XIzaKCRR2hssIjF07kZFEiieALBM/ARQ=
+golang.org/x/exp v0.0.0-20250207012021-f9890c6ad9f3 h1:qNgPs5exUA+G0C96DrPwNrvLSj7GT/9D+3WMWUcUg34=
+golang.org/x/exp v0.0.0-20250207012021-f9890c6ad9f3/go.mod h1:tujkw807nyEEAamNbDrEGzRav+ilXA7PCRAd6xsmwiU=
 golang.org/x/mod v0.16.0 h1:QX4fJ0Rr5cPQCF7O9lh9Se4pmwfwskqZfq5moyldzic=
 golang.org/x/mod v0.16.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
+golang.org/x/mod v0.23.0 h1:Zb7khfcRGKk+kqfxFaP5tZqCnDZMjC5VtUBs87Hr6QM=
+golang.org/x/mod v0.23.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
 golang.org/x/sys v0.0.0-20210320140829-1e4c9ba3b0c4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.17.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/sys v0.18.0 h1:DBdB3niSjOA/O0blCZBqDefyWNYveAYMNF1Wum0DYQ4=
 golang.org/x/sys v0.18.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
+golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/term v0.17.0/go.mod h1:lLRBjIVuehSbZlaOtGMbcMncT+aqLLLmKrsjNrUguwk=
 golang.org/x/term v0.18.0 h1:FcHjZXDMxI8mM3nwhX9HlKop4C0YQvCVCdwYl2wOtE8=
 golang.org/x/term v0.18.0/go.mod h1:ILwASektA3OnRv7amZ1xhE/KTR+u50pbXfZ03+6Nx58=
+golang.org/x/term v0.29.0 h1:L6pJp37ocefwRRtYPKSWOWzOtWSxVajvz2ldH/xi3iU=
+golang.org/x/term v0.29.0/go.mod h1:6bl4lRlvVuDgSf3179VpIxBF0o10JUpXWOnI7nErv7s=
 gonum.org/v1/gonum v0.15.0 h1:2lYxjRbTYyxkJxlhC+LvJIx3SsANPdRybu1tGj9/OrQ=
 gonum.org/v1/gonum v0.15.0/go.mod h1:xzZVBJBtS+Mz4q0Yl2LJTk+OxOg4jiXZ7qBoM0uISGo=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
diff --git a/language/golang/language.go b/language/golang/language.go
@@ -140,6 +140,9 @@ func parseSymflowerTestOutput(data string) (testsTotal int, testsPass int, err e
 		}
 	}
 	testsPass = testsTotal - testsFail
+	if testsPass < 0 { // Go does not count tests on syntax errors, but marks it as a failing test. This results in total tests 0 minus failing tess 1, hence, -1. Passing tests should be always >=0.
+		testsPass = 0
+	}
 
 	return testsTotal, testsPass, nil
 }
diff --git a/language/golang/language_test.go b/language/golang/language_test.go
@@ -305,4 +305,27 @@ func TestParseSymflowerTestOutput(t *testing.T) {
 		ExpectedTestsTotal: 6,
 		ExpectedTestsPass:  4,
 	})
+	validate(t, &testCase{
+		Name: "Tests with syntax error in implementation (Go >=1.23)",
+
+		Data: `
+			# cascadingIfElse [cascadingIfElse.test]
+			./cascadingIfElse.go:3:8: "strings" imported and not used
+			FAIL    cascadingIfElse [build failed]
+
+			=== Failed
+			=== FAIL: .  (0.00s)
+			FAIL    cascadingIfElse [build failed]
+
+			=== Errors
+			./cascadingIfElse.go:3:8: "strings" imported and not used
+
+			DONE 0 tests, 1 failure, 1 error in 0.117s
+			Give us your feedback and let us know how we can improve Symflower at hello@symflower.com or https://github.com/symflower/symflower. Thanks so much for your help!
+			ERROR: execution failed: exit status 1
+		`,
+
+		ExpectedTestsTotal: 0,
+		ExpectedTestsPass:  0,
+	})
 }
diff --git a/scripts/deadcode/main.go b/scripts/deadcode/main.go
@@ -31,7 +31,10 @@ func main() {
 		},
 	})
 	if err != nil {
-		panic([]any{err, logBuffer.String()})
+		fmt.Println(output)
+		fmt.Println(logBuffer.String())
+
+		panic(err)
 	}
 
 	var matches []string
diff --git a/scripts/eval-dev-quality-release/main.go b/scripts/eval-dev-quality-release/main.go
@@ -54,7 +54,10 @@ func main() {
 		},
 	})
 	if err != nil {
-		logger.Info("cannot update repository to the latest commits: %+v", err)
+		logger.Warn(
+			"cannot update repository to the latest commits:",
+			"error", err,
+		)
 	}
 
 	logger.Info("check that version is newer than current version")
diff --git a/testdata/golang/light/go.mod b/testdata/golang/light/go.mod
@@ -1,5 +1,5 @@
 module light
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/mistakes/importMissing/go.mod b/testdata/golang/mistakes/importMissing/go.mod
@@ -1,5 +1,5 @@
 module importMissing
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/mistakes/openingBracketMissing/go.mod b/testdata/golang/mistakes/openingBracketMissing/go.mod
@@ -1,5 +1,5 @@
 module openingBracketMissing
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/mistakes/syntaxErrorTypeMissing/go.mod b/testdata/golang/mistakes/syntaxErrorTypeMissing/go.mod
@@ -1,5 +1,5 @@
 module syntaxErrorTypeMissing
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/mistakes/typeUnknown/go.mod b/testdata/golang/mistakes/typeUnknown/go.mod
@@ -1,5 +1,5 @@
 module typeUnknown
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/mistakes/variableUnknown/go.mod b/testdata/golang/mistakes/variableUnknown/go.mod
@@ -1,5 +1,5 @@
 module variableUnknown
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/plain/go.mod b/testdata/golang/plain/go.mod
@@ -1,3 +1,3 @@
 module plain
 
-go 1.21.5
+go 1.23.6
diff --git a/testdata/golang/transpile/balancedBrackets/go.mod b/testdata/golang/transpile/balancedBrackets/go.mod
@@ -1,5 +1,5 @@
 module balancedBrackets
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/transpile/binarySearch/go.mod b/testdata/golang/transpile/binarySearch/go.mod
@@ -1,5 +1,5 @@
 module binarySearch
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/transpile/cascadingIfElse/go.mod b/testdata/golang/transpile/cascadingIfElse/go.mod
@@ -1,5 +1,5 @@
 module cascadingIfElse
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/transpile/isSorted/go.mod b/testdata/golang/transpile/isSorted/go.mod
@@ -1,5 +1,5 @@
 module isSorted
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect
diff --git a/testdata/golang/transpile/pascalsTriangle/go.mod b/testdata/golang/transpile/pascalsTriangle/go.mod
@@ -1,5 +1,5 @@
 module pascalsTriangle
 
-go 1.21.5
+go 1.23.6
 
 require github.com/stretchr/testify v1.9.0 // indirect

-Original file line number
+Diff line change
 install-tools-linting: # Install tools that are used for linting.
 	go install -v github.com/kisielk/[email protected]
 	go install -v github.com/mgechev/[email protected]
 -	go install -v golang.org/x/tools/cmd/deadcode@v0.16.1
 +	go install -v golang.org/x/tools/cmd/deadcode@v0.27.1-0.20241219162658-575221bfbda3 # Aligned with version `gopls/v0.17.1`.
 	go install -v honnef.co/go/tools/cmd/[email protected]
 .PHONY: install-tools-linting
Original file line number	Diff line number	Diff line change
`@@ -629,7 +629,10 @@ func (command Evaluate) evaluateDocker(ctx evaluate.Context) (err error) {`
`629`	`629`	`Command: cmd,`
`630`	`630`	`})`
`631`	`631`	`if err != nil {`
`632`		`- ctx.Log.Error("ERROR: Unable to pull image", pkgerrors.WithMessage(pkgerrors.WithStack(err), commandOutput))`
	`632`	`+ ctx.Log.Error(`
	`633`	`+ "ERROR: unable to pull image",`
	`634`	`+ "error", pkgerrors.WithMessage(pkgerrors.WithStack(err), commandOutput),`
	`635`	`+ )`
`633`	`636`	`}`
`634`	`637`	`}`
`635`	`638`
Original file line number	Diff line number	Diff line change
`@@ -140,6 +140,9 @@ func parseSymflowerTestOutput(data string) (testsTotal int, testsPass int, err e`
`140`	`140`	`}`
`141`	`141`	`}`
`142`	`142`	`testsPass = testsTotal - testsFail`
	`143`	`+ if testsPass < 0 { // Go does not count tests on syntax errors, but marks it as a failing test. This results in total tests 0 minus failing tess 1, hence, -1. Passing tests should be always >=0.`
	`144`	`+ testsPass = 0`
	`145`	`+ }`
`143`	`146`
`144`	`147`	`return testsTotal, testsPass, nil`
`145`	`148`	`}`