-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add support for php.new (herd-lite) #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wrote some directions in the main repo to do so: https://github.com/symfony-cli/symfony-cli/blob/main/CONTRIBUTING.md#additional-repositories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we add support for php.new on Linux and macOS as well?
Totally, given the installation files, PHP should be available at |
Great 👍 |
PR updated, I still didn't try it locally tho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small cosmetic suggestion, but LGTM overall
Co-authored-by: Tugdual Saunier <[email protected]>
I suppose it works, but I haven't been able to test it.
With Go, how can I use my PR with the Symfony CLI, so I can try to see if
local:php:list
gives me PHP from herd-lite directory?Close #25