feat: add support for flavor selection

[tucksaun]

As a maintainer, I need on a regular basis to pick specific server type to reproduce issues.
But patching source code to do so is:
a. cumbersome
b. error prone

And sometimes this can be useful for users as well (imagine you have a 8.4.5 installed with CLI only and 8.4.4 with FPM and CLI and your project requires FPM for instance).

This also lays the ground to pick more variants (debug or zts for example)

[Copilot]

Pull Request Overview

This PR adds support for selecting specific PHP “flavors” (cli, cgi, fpm, frankenphp) when discovering and choosing versions. Key changes include:

• Introduction of Flavor* constants, SupportsFlavor and ForceFlavorIfSupported methods in version.go
• Parsing of optional -flavor suffix in bestVersion and filtering by flavor in store.go
• New tests in version_test.go and extended store_test.go to cover flavor-based selection

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
version.go	Added flavor constants, override field, SupportsFlavor and ForceFlavorIfSupported, updated serverType
version_test.go	Added tests for SupportsFlavor covering all flavor cases
store.go	Added newEmpty, updated bestVersion to parse flavor suffix and filter versions
store_test.go	Switched to newEmpty, added sorting, extended TestBestVersion to validate “-fpm” requirement

Comments suppressed due to low confidence (3)

version.go:61

• [nitpick] The field name typeOverride is not immediately clear; consider renaming to overrideServerType or forcedServerType for better readability.

	typeOverride serverType

version.go:144

• Public methods should have doc comments. Add a comment explaining what ForceFlavorIfSupported does, its side-effects on the Version, and when it should be used.

func (v *Version) ForceFlavorIfSupported(flavor string) bool {

version.go:144

• There are no tests covering ForceFlavorIfSupported. Add unit tests to verify that it correctly applies overrides only when the flavor is supported and doesn’t apply when unsupported.

func (v *Version) ForceFlavorIfSupported(flavor string) bool {

[Copilot]

Calling ForceFlavorIfSupported here mutates the Version (setting typeOverride) during lookup, which can leak state across calls. Consider using SupportsFlavor for filtering and only applying ForceFlavorIfSupported when actually selecting a version to avoid unintended side-effects.

Suggested change

	if v.Version == versionPrefix && v.ForceFlavorIfSupported(flavor) {
	if v.Version == versionPrefix && v.SupportsFlavor(flavor) {
	v.ForceFlavorIfSupported(flavor)

[tucksaun]

@fabpot, what do you think about this one? My goal was to avoid unnecessary double checks because selecting the best PHP version is somewhat on the hot path for the CLI.

[fabpot]

I don't think the overhead is significant.

[tucksaun]

updated

[tucksaun]

@fabpot did you get a chance to review the updated version?

[Copilot]

Same issue as above: using ForceFlavorIfSupported here changes the Version state during iteration. Swap this for a pure SupportsFlavor check, and defer state changes until after the best match is chosen.

Suggested change

	if strings.HasPrefix(v.Version, versionPrefix) && v.ForceFlavorIfSupported(flavor) {
	if strings.HasPrefix(v.Version, versionPrefix) && v.SupportsFlavor(flavor) {
	v.ForceFlavorIfSupported(flavor) // Apply state change after match is chosen