Skip to content

implement sitemap and error handling of seo-bundle #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

implement sitemap and error handling of seo-bundle #352

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f7841da
implement sitemap and error handling of seo-bundle
ElectricMaxxx Oct 27, 2016
42475f6
changes due to hints of styleCI
ElectricMaxxx Oct 27, 2016
c1a67a2
re-add former error text and information
ElectricMaxxx Oct 27, 2016
482cfc1
test for error page
ElectricMaxxx Oct 27, 2016
32764d2
add error description page
ElectricMaxxx Oct 28, 2016
b566cf7
remove french translation
ElectricMaxxx Nov 2, 2016
11714cb
fix ci test
ElectricMaxxx Nov 2, 2016
f9fea5e
fix issues due to hints
ElectricMaxxx Dec 13, 2016
ae1ba37
Apply fixes from StyleCI
ElectricMaxxx Dec 13, 2016
99620d1
Merge pull request #355 from symfony-cmf/analysis-8wkK9e
ElectricMaxxx Dec 13, 2016
42081c0
translate seo examples
dbu Nov 8, 2016
19dea4f
Merge pull request #356 from symfony-cmf/seo-translations
dbu Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/AppBundle/Document/DemoSeoExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@
*
* @author Maximilian Berghoff <[email protected]>
*/
class DemoSeoExtractor extends DemoSeoContent implements
TitleReadInterface,
DescriptionReadInterface,
OriginalUrlReadInterface,
KeywordsReadInterface
class DemoSeoExtractor extends DemoSeoContent implements TitleReadInterface, DescriptionReadInterface, OriginalUrlReadInterface, KeywordsReadInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather disable this fixer and keep this multiline to make it readable. put disabled: [single_line_class_definition] into .styleci.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. we should use that everywhere, cause i saw that on seo-bundle yesterday too. from which coding style is that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouter added it in one of the bundles, can't remember which one

{
/**
* {@inheritdoc}
Expand Down
1 change: 0 additions & 1 deletion web/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
$kernel->loadClassCache();
//$kernel = new AppCache($kernel);


// When using the HttpCache, you need to call the method in your front
// controller instead of relying on the configuration parameter
//Request::enableHttpMethodParameterOverride();
Expand Down