fixing a bug where subscribers would incorrectly mark something as unsupported

... even though another subscriber might support this

Author: weaverryan

src/Issues/GitHubRequestHandler.php

@@ -81,6 +81,10 @@ public function handle(Request $request)
 
         $responseData = $event->getResponseData();
 
+        if (empty($responseData)) {
+            $responseData['unsupported_action'] = $eventName;
+        }
+
         return $responseData;
     }
 

src/Subscriber/AutoLabelPRFromContentSubscriber.php

@@ -36,8 +36,6 @@ public function onPullRequest(GitHubEvent $event)
     {
         $data = $event->getData();
         if ('opened' !== $action = $data['action']) {
-            $event->setResponseData(array('unsupported_action' => $action));
-
             return;
         }
 

src/Subscriber/BugLabelNewIssueSubscriber.php

@@ -30,8 +30,6 @@ public function onIssues(GitHubEvent $event)
         $data = $event->getData();
         $repository = $event->getRepository();
         if ('labeled' !== $action = $data['action']) {
-            $event->setResponseData(array('unsupported_action' => $action));
-
             return;
         }
 

src/Subscriber/NeedsReviewNewPRSubscriber.php

@@ -27,8 +27,6 @@ public function onPullRequest(GitHubEvent $event)
         $data = $event->getData();
         $repository = $event->getRepository();
         if ('opened' !== $action = $data['action']) {
-            $event->setResponseData(array('unsupported_action' => $action));
-
             return;
         }
 

src/Subscriber/StatusChangeByReviewSubscriber.php

@@ -33,8 +33,6 @@ public function onReview(GitHubEvent $event)
     {
         $data = $event->getData();
         if ('submitted' !== $data['action']) {
-            $event->setResponseData(array('unsupported_action' => $data['action']));
-
             return;
         }
 
@@ -82,8 +80,6 @@ public function onReviewRequested(GithubEvent $event)
     {
         $data = $event->getData();
         if ('review_requested' !== $data['action']) {
-            $event->setResponseData(array('unsupported_action' => $data['action']));
-
             return;
         }
 

src/Subscriber/StatusChangeOnPushSubscriber.php

@@ -27,8 +27,6 @@ public function onPullRequest(GitHubEvent $event)
     {
         $data = $event->getData();
         if ('synchronize' !== $data['action']) {
-            $event->setResponseData(array('unsupported_action' => $data['action']));
-
             return;
         }
 

tests/Subscriber/BugLabelNewIssueSubscriberTest.php

@@ -153,7 +153,6 @@ public function testOnIssuesIgnoresNonLabeled()
 
         $responseData = $event->getResponseData();
 
-        $this->assertCount(1, $responseData);
-        $this->assertSame('close', $responseData['unsupported_action']);
+        $this->assertEmpty($responseData);
     }
 }

tests/Subscriber/NeedsReviewNewPRSubscriberTest.php

@@ -67,7 +67,6 @@ public function testOnPullRequestNotOpen()
 
         $responseData = $event->getResponseData();
 
-        $this->assertCount(1, $responseData);
-        $this->assertSame('close', $responseData['unsupported_action']);
+        $this->assertEmpty($responseData);
     }
 }

tests/Subscriber/StatusChangeOnPushSubscriberTest.php

@@ -91,8 +91,7 @@ public function testOnNonPushPullRequestEvent()
 
         $responseData = $event->getResponseData();
 
-        $this->assertCount(1, $responseData);
-        $this->assertSame('labeled', $responseData['unsupported_action']);
+        $this->assertEmpty($responseData);
     }
 
     public function testWipPullRequest()