feat: Add option to generate Gitlab compatible endpoints #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add provider option to GenerateFlexEndpointCommand
nicolas-grekas
approved these changes
Apr 16, 2025
Co-authored-by: Nicolas Grekas <[email protected]>
stof
reviewed
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The documentation for private recipes repositories include examples for using it with Gitlab.com (https://symfony.com/doc/current/setup/flex_private_recipes.html). But this project do not have the possibility to generate endpoints compatible with it.
I added the option
--provider=, with default value to "github", in thegenerate:flex-endpointcommand to specify a provider (only Github or Gitlab for now). This will change how the_linkskey is generated in the index.json.Closes #13