feat: Allow multiple lines addition with array #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the developer experience for writing recipes by allowing an array of strings for the content key in the add-lines configurator. First try was on symfony/flex#1034
To ensure 100% backward compatibility with all existing versions of symfony/flex, the implementation is twofold:
LintManifestsCommand: The linter is updated to validate and accept an array of strings for the content key. This allows the new, more readable format to be used in the source recipe repositories.GenerateFlexEndpointCommand: During the generation of the public Flex endpoint, the command now automatically detects if content is an array and converts it back into a single, \n-separated string.Recipe: https://github.com/MforMono/recipes/blob/main/friends-of-behat/mink-extension/2.4/manifest.json
Generated json: https://github.com/MforMono/recipes/blob/flex/main/friends-of-behat.mink-debug-extension.2.0.json