Skip to content

Remove legacy twig.exception_controller option #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

Remove legacy twig.exception_controller option #39

merged 1 commit into from
Sep 25, 2025

Conversation

nicolas-grekas
Copy link
Contributor

@javiereguiluz
Copy link
Contributor

Thanks for fixing this.

But, I'm trying to understand why this started failing suddenly today? Shouldn't we see a deprecation message instead?

@nicolas-grekas
Copy link
Contributor Author

nicolas-grekas commented Sep 25, 2025 •
edited
Loading

That's because of symfony/symfony#51273 (comment)
We could go with a deprecation, but honestly this is trivial to fix and is quite old...

@javiereguiluz
Copy link
Contributor

Thanks Nicolas.

@javiereguiluz javiereguiluz merged commit 277d83b into 5.4 Sep 25, 2025
0 of 2 checks passed
@javiereguiluz javiereguiluz deleted the no-ex-ctrl branch September 25, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @javiereguiluz @xabbuh