[Platform] ElevenLabs definitions rework#1273
Closed
Guikingone wants to merge 1 commit intosymfony:mainfrom
Closed
[Platform] ElevenLabs definitions rework#1273Guikingone wants to merge 1 commit intosymfony:mainfrom
ElevenLabs definitions rework#1273Guikingone wants to merge 1 commit intosymfony:mainfrom
Conversation
Guikingone
changed the title
ElevenLabs improvements
OskarStark
reviewed
Dec 23, 2025
Guikingone
changed the title
ElevenLabs improvementsElevenLabs definitions rework
Guikingone
force-pushed
the
refactor/elevenlabs_platform
branch
from
48c578e to
d1ecab3
Compare
carsonbot
added
Feature
Guikingone
force-pushed
the
refactor/elevenlabs_platform
branch
2 times, most recently
from
2501ddd to
8df4dee
Compare
Guikingone
force-pushed
the
refactor/elevenlabs_platform
branch
from
8df4dee to
d826c77
Compare
chr-hertel
requested changes
Dec 31, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Not completely sold on the need for decoration, but let's isolate the two things here:
- rework on bundle, skipping the factory
- removing the
PlatformFactory
For the second one I would be quite reluctant because that is quite handy when not using the bundle, what - at least for me - is the case regularly in prototypes not requiring the entire framework.
Member
|
@Guikingone want to continue on the first one here or not needed anymore?
|
Contributor
Author
|
Hi @chr-hertel 👋🏻 Not needed anymore, this PR was built to ease #943 but the PR is ready without impacting services, I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
Here's a POC for #1265, I choose EL as it's the easiest to refactor and the easiest to configure, this PR allows to remove the factory usage, add missing services / tags and rework the injection process, every class is now a service and can be decorated / lazy-loaded.