Conversation
8655595 to
f2d0633
Compare
|
Hey @Guikingone, we had quite some BC breaks in store lately and a new integration test setup - can you adopt that here please? |
15c57cf to
7ad776e
Compare
|
Fabbot is complaining due to the name of the library, not a big deal IMHO 😅 |
|
@centamiv If you want to take a look 🙂 |
|
@Guikingone thanks for working on this integration! I took a look at the code and the implementation seems perfectly aligned with the library. Just let me know if you need me to add any tests or features to solve specific use cases. |
7ad776e to
776c9b5
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds a new Vektor vector store bridge to the Symfony AI Store component. Vektor is a PHP-based vector database library that stores data on the filesystem. The PR introduces support for this store backend, following the established patterns of other store bridges in the monorepo.
Changes:
- Adds a new Vektor store bridge package with Store implementation, tests, and configuration
- Integrates the Vektor store into the AI Bundle with configuration support
- Adds a RAG example demonstrating Vektor store usage
- Updates the monorepo's splitsh.json to include the new bridge for subtree splitting
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/src/Bridge/Vektor/Store.php | Main Store implementation that wraps the Vektor library, implementing StoreInterface and ManagedStoreInterface |
| src/store/src/Bridge/Vektor/Tests/StoreTest.php | Unit tests for Store class covering setup, drop, optimize, and query operations |
| src/store/src/Bridge/Vektor/Tests/IntegrationTest.php | Integration test extending AbstractStoreIntegrationTestCase for comprehensive testing |
| src/store/src/Bridge/Vektor/composer.json | Package configuration with dependencies on centamiv/vektor ^2.0.1 and symfony components |
| src/store/src/Bridge/Vektor/phpunit.xml.dist | PHPUnit configuration for running bridge tests |
| src/store/src/Bridge/Vektor/phpstan.dist.neon | PHPStan static analysis configuration |
| src/store/src/Bridge/Vektor/README.md | Documentation describing the bridge and linking to resources |
| src/store/src/Bridge/Vektor/CHANGELOG.md | Changelog documenting the addition in version 0.5 |
| src/store/src/Bridge/Vektor/LICENSE | MIT license file |
| src/store/src/Bridge/Vektor/.gitignore | Git ignore rules for vendor, composer.lock, and test artifacts |
| src/store/src/Bridge/Vektor/.gitattributes | Export ignore rules for tests and development files |
| src/store/src/Bridge/Vektor/.github/workflows/close-pull-request.yml | GitHub workflow to redirect PRs to main repository |
| src/store/src/Bridge/Vektor/.github/PULL_REQUEST_TEMPLATE.md | PR template redirecting to main repository |
| src/ai-bundle/src/AiBundle.php | Adds Vektor store registration logic in processStoreConfig method |
| src/ai-bundle/config/store/vektor.php | Configuration definition for Vektor stores with storage_path and dimensions options |
| src/ai-bundle/config/options.php | Imports Vektor store configuration into main AI Bundle config |
| src/ai-bundle/tests/DependencyInjection/AiBundleTest.php | Tests for Vektor store configuration with various option combinations |
| src/ai-bundle/composer.json | Adds symfony/ai-vektor-store ^0.5 to require-dev |
| examples/rag/vektor.php | Example demonstrating RAG with Vektor store, SimilaritySearch, and OpenAI |
| examples/composer.json | Adds symfony/ai-vektor-store ^0.5 to require-dev |
| splitsh.json | Adds ai-vektor-store entry for repository splitting |
776c9b5 to
69b5379
Compare
|
I closed two suggestions of Copilot about using |
acb99e0 to
c393763
Compare
c5d4415 to
4213229
Compare
4213229 to
f2a2e52
Compare
f2a2e52 to
1bfc23c
Compare
1bfc23c to
74d4164
Compare
|
Thank you @Guikingone. |
… (chr-hertel) This PR was merged into the main branch. Discussion ---------- [Store][Vektor] Run Vektor integration test in pipeline | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Follows #1561 Commits ------- 610f0c6 Run Vektor integration test in pipeline
…ipeline (chr-hertel) This PR was merged into the main branch. Discussion ---------- [Store][Vektor] Run Vektor integration test in pipeline | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Follows symfony#1561 Commits ------- 610f0c6 Run Vektor integration test in pipeline
…ertel) This PR was merged into the main branch. Discussion ---------- [Examples] Fix composer setup of examples before 0.6 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Follows #1561 and #1554. We should never require unreleased versions when no branch-alias is defined, and since we bump the versions prior to release we can go with `dev-main`. cc `@OskarStark` `@Guikingone` Commits ------- 5044821 Fix composer setup of examples before 0.6
Vektor