Skip to content

Drop Symfony 6.4 support, require ^7.3|^8.0 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OskarStark
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Docs? no
Issues --
License MIT
  • Update all composer.json files to require Symfony ^7.3|^8.0
  • Minimum supported version is now Symfony 7.3 LTS

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rolling that out - there should also be some code that I annotated with 6.4 comments - but can easily remove that in a follow up

@OskarStark OskarStark force-pushed the drop-symfony-6.4-support branch 2 times, most recently from fb2605a to 6080ad7 Compare August 6, 2025 21:23
@Nyholm
Copy link
Member

Nyholm commented Aug 6, 2025

Why do we want to drop 6.4?

I don't think there is a big burden to support it and it it a huge benefit for adoption of we keep it.

Or am I missing something?

@fabpot
Copy link
Member

fabpot commented Aug 7, 2025

Why do we want to drop 6.4?

I don't think there is a big burden to support it and it it a huge benefit for adoption of we keep it.

Or am I missing something?

If you're not able to upgrade to a non-LTS version of Symfony, you will probably not be able to use Symfony AI, which is not stable yet (and probably not before the release of 7.4 LTS), you will probably not be able to upgrade Symony AI frequently which is going to be needed as the space is changing fast.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI failures look related

@OskarStark
Copy link
Contributor Author

the CI failures look related

yes, but I think this is due to the fact that not all Symfony components allow 7.4|8 ? just my guess

- Update all composer.json files to require Symfony ^7.3|^8.0
- Update symfony/type-info to ^7.3|^8.0
- Adjust GitHub Actions test matrix:
  - Replace Symfony 6.4 test with Symfony 7.4 LTS
  - Add explicit Symfony 8.0 test
  - Update SYMFONY_REQUIRE baseline to >=7.3
- Remove Symfony 6.4 compatibility code:
  - Remove unnecessary try-catch blocks for JsonException
  - Replace custom jsonMockResponseFromFile helper with built-in JsonMockResponse::fromFile
  - Clean up compatibility comments
@derrabus
Copy link
Member

derrabus commented Aug 7, 2025

the CI failures look related

yes, but I think this is due to the fact that not all Symfony components allow 7.4|8 ? just my guess

No, it's because you're pinning to unstable Symfony branches while requesting stable dependencies.

@OskarStark
Copy link
Contributor Author

Ok, so we can only merge this, once 7.4 and 8.0 are released?

@derrabus
Copy link
Member

derrabus commented Aug 7, 2025

No, you'll have to lower the minimum stability to dev. Either globally for the project (as we do on symfony/symfony) or on those two CI jobs.

@valtzu
Copy link
Contributor

valtzu commented Aug 8, 2025

👎 from me (at least until 7.4 is out). This will change a one-week proof-of-concept to a bigger "upgrade symfony" project for many companies – assuming that companies prefer LTS (yet are fine running symfony/ai@dev).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants