-
-
Notifications
You must be signed in to change notification settings - Fork 50
[Platform] Add ElevenLabs as platform #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4d17e07
to
2abb1b5
Compare
src/platform/src/Bridge/ElevenLabs/ElevenLabsResultConverter.php
Outdated
Show resolved
Hide resolved
@@ -45,6 +45,7 @@ public function normalize(mixed $data, ?string $format = null, array $context = | |||
'type' => 'input_audio', | |||
'input_audio' => [ | |||
'data' => $data->asBase64(), | |||
'path' => $data->asPath(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that have impact to other audio examples, e.g. examples/openai/audio-input.php
? maybe we need to isolate that in an elevenlabs specific contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, open to debate on this one, the $path
attribut is always defined (I agree on the fact that it can be null) thanks to File
so IMHO, using the method is not a problem (when correctly typed), returning an array with a value "null" in certain cases is not a problem as long as the API is typed to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It breaks the example openai/audio-input.php
- please revert and bring in another Normalizer specifically for ElevenLabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a bit in a hurry but left some comments - definitely looking forward to play around with it - thanks for working on it! 🙏
2abb1b5
to
85fae76
Compare
a2e3bcf
to
dbd8dfe
Compare
af32ada
to
c1b3ae4
Compare
c1b3ae4
to
ee43d7b
Compare
Hi 👋🏻
As discussed in #263,
ElevenLabs
can be more than just a tool for agents, the idea of a platform was discussed so here it is.PS: Both TTS and STT examples are working "as expected" (the TTS one generate a file as we can't run the file).