[AIBundle] Cache store configuration improved #293
+188
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
Guikingone
force-pushed
the
store/cache_fix
branch
from
47ab79e to
387d719
Compare
OskarStark
reviewed
Aug 8, 2025
Guikingone
force-pushed
the
store/cache_fix
branch
from
546c2d9 to
2368215
Compare
chr-hertel
reviewed
Aug 9, 2025
Guikingone
force-pushed
the
store/cache_fix
branch
from
2368215 to
fa5adf4
Compare
Guikingone
force-pushed
the
store/cache_fix
branch
from
3680a9e to
987fd0a
Compare
chr-hertel
reviewed
Aug 10, 2025
OskarStark
approved these changes
Aug 11, 2025
chr-hertel
reviewed
Aug 11, 2025
Comment on lines
+36
to
+38
| if (!interface_exists(CacheInterface::class)) { | ||
| throw new RuntimeException('For using the CacheStore as vector store, a symfony/contracts cache implementation is required. Try running "composer require symfony/cache" or another symfony/contracts compatible cache.'); | ||
| } |
There was a problem hiding this comment.
Why is that check needed as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
The configuration wasn't complete enough to handle custom strategy / key for the cache store, here's the fix, tests are validated (both in the project and in a custom project too).