-
-
Notifications
You must be signed in to change notification settings - Fork 102
[Store][Supabase] Add store #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Store][Supabase] Add store #551
Conversation
27c5049
to
76610d8
Compare
76610d8
to
e962da1
Compare
->useAttributeAsKey('name') | ||
->arrayPrototype() | ||
->children() | ||
->scalarNode('url')->isRequired()->cannotBeEmpty()->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see it done for any other store. Am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a rebase you should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still sclaraNode()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand.
Could you help me here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, sure, please use stringNode() or integerNode()
e962da1
to
7758745
Compare
Addressed the review. |
7758745
to
f0bd639
Compare
We try to keep the code a little bit in sync. What coding standards do you mean? |
f0bd639
to
390c3c1
Compare
- Adds support for supabase
- Adds bundle integration - Adds an entry into the stores factory for supabase
- Adds documentation for the new store integration
390c3c1
to
f53dfe5
Compare
Something like a contributing guide or PSR that specifically details the coding standards to be followed when contributing to the repo. This will ensure we have a consistent coding style throughout the codebase without having the maintainers worry much about it IMO. |
This PR adds support for Supabase as a vector store backend, leveraging Supabase's pgvector extension through the REST API.
Features
Key Differences from Postgres Store
Unlike the direct Postgres store, the Supabase bridge: