[Platform] Add generic exceptions #574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaidbinfarooq
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Feature
carsonbot
changed the title
junaidbinfarooq
force-pushed
the
feat/issue-528-add-generic-api-errors
branch
from
fb02868 to
65af651
Compare
chr-hertel
added
the
Hackathon 2025
- Adds exceptions for 404 and 503 - Adds a generic http error handler
- Fixes tests
junaidbinfarooq
force-pushed
the
feat/issue-528-add-generic-api-errors
branch
3 times, most recently
from
282f91c to
59746d1
Compare
- Adds logic, to handle rate limit exception, to the handler
junaidbinfarooq
force-pushed
the
feat/issue-528-add-generic-api-errors
branch
from
59746d1 to
d5f9325
Compare
|
@chr-hertel @OskarStark |
chr-hertel
added a commit
that referenced
this pull request
Sep 28, 2025
…oesteve) This PR was squashed before being merged into the main branch. Discussion ---------- [Platform][OpenAI] Improve error reporting for Bad Request | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | Fix #528 | License | MIT I've noted an interesting initiative at #574 to handle non-valid response codes in a more structured and scalable way. This approach makes sense to me, but it may require further reflection. With this PR, I aim to contribute a humble and specific use case for OpenAI, along with an Exception class that could be reused for the other bridges. Commits ------- c39bbbf [Platform][OpenAI] Improve error reporting for Bad Request
symfony-splitter
pushed a commit
to symfony/ai-platform
that referenced
this pull request
Sep 28, 2025
…oesteve) This PR was squashed before being merged into the main branch. Discussion ---------- [Platform][OpenAI] Improve error reporting for Bad Request | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | Fix #528 | License | MIT I've noted an interesting initiative at symfony/ai#574 to handle non-valid response codes in a more structured and scalable way. This approach makes sense to me, but it may require further reflection. With this PR, I aim to contribute a humble and specific use case for OpenAI, along with an Exception class that could be reused for the other bridges. Commits ------- c39bbbf4 [Platform][OpenAI] Improve error reporting for Bad Request
|
@chr-hertel @OskarStark |
devmatt000
pushed a commit
to devmatt000/dev_ai
that referenced
this pull request
Oct 2, 2025
…oesteve) This PR was squashed before being merged into the main branch. Discussion ---------- [Platform][OpenAI] Improve error reporting for Bad Request | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | Fix #528 | License | MIT I've noted an interesting initiative at symfony/ai#574 to handle non-valid response codes in a more structured and scalable way. This approach makes sense to me, but it may require further reflection. With this PR, I aim to contribute a humble and specific use case for OpenAI, along with an Exception class that could be reused for the other bridges. Commits ------- c39bbbf4 [Platform][OpenAI] Improve error reporting for Bad Request
|
@junaidbinfarooq I'm currently not really convinced that it should be the role of result converters to handle this stuff. see #646 #136 and #167 please don't spend more time here - not closing for now, since we might come back to this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
The PR aims to add the following: