Skip to content

[Platform] Add status code 429 to rate limit exceeded exception #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

[Platform] Add status code 429 to rate limit exceeded exception #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/src/Exception/RateLimitExceededException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ final class RateLimitExceededException extends RuntimeException
public function __construct(
private readonly ?float $retryAfter = null,
) {
parent::__construct('Rate limit exceeded.');
parent::__construct('Rate limit exceeded.', 429);
}

public function getRetryAfter(): ?float
Expand Down
2 changes: 2 additions & 0 deletions src/platform/tests/Bridge/Anthropic/ResultConverterRateLimitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public function testRateLimitExceededThrowsException()
$handler = new ResultConverter();

$this->expectException(RateLimitExceededException::class);
$this->expectExceptionCode(429);
$this->expectExceptionMessage('Rate limit exceeded');

try {
Expand All @@ -61,6 +62,7 @@ public function testRateLimitExceededWithoutRetryAfter()
$handler = new ResultConverter();

$this->expectException(RateLimitExceededException::class);
$this->expectExceptionCode(429);
$this->expectExceptionMessage('Rate limit exceeded');

try {
Expand Down
1 change: 1 addition & 0 deletions src/platform/tests/Bridge/Gemini/Gemini/ResultConverterRateLimitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public function testRateLimitExceededThrowsException()
$handler = new ResultConverter();

$this->expectException(RateLimitExceededException::class);
$this->expectExceptionCode(429);
$this->expectExceptionMessage('Rate limit exceeded.');

try {
Expand Down
2 changes: 2 additions & 0 deletions src/platform/tests/Bridge/OpenAi/Gpt/ResultConverterRateLimitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public function testRateLimitExceededWithRequestsResetTime()
$handler = new ResultConverter();

$this->expectException(RateLimitExceededException::class);
$this->expectExceptionCode(429);
$this->expectExceptionMessage('Rate limit exceeded.');

try {
Expand Down Expand Up @@ -68,6 +69,7 @@ public function testRateLimitExceededWithTokensResetTime()
$handler = new ResultConverter();

$this->expectException(RateLimitExceededException::class);
$this->expectExceptionCode(429);
$this->expectExceptionMessage('Rate limit exceeded.');

try {
Expand Down