Skip to content

[Chat] Introduce a new component #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

[Chat] Introduce a new component #675

merged 1 commit into from
Oct 3, 2025

Conversation

Guikingone
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues Related to #254
License MIT

Hi 👋🏻

Ok, time to tackle the big work on the #254 issue, the current structure doesn't allows to introduce new stores neither handling the storage of messages, mainly due to the fact that we can't intervene in the agent component without breaking the SRP of it.

This PR aims to split the Chat into a new component and ease the work on storing messages (with a new component, we can easily add storages here rather than in the agent component), plus, it helps splitting the responsibilities inside the initiative as we should be allowed to start new agents without relying on any chats.

This PR is a draft, feel free to open debates about it 😄

@Guikingone Guikingone changed the title [Chat] Introduce new component [Chat] Introduce a new component Sep 25, 2025
OskarStark
OskarStark reviewed Sep 25, 2025
View reviewed changes
@OskarStark
Copy link
Contributor

I like having a new component for this

@Guikingone Guikingone marked this pull request as ready for review September 26, 2025 11:54
@OskarStark OskarStark mentioned this pull request Sep 26, 2025
Merged
chr-hertel
chr-hertel reviewed Sep 26, 2025
View reviewed changes
chr-hertel
chr-hertel reviewed Sep 26, 2025
View reviewed changes
chr-hertel
chr-hertel requested changes Sep 26, 2025
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a readme, right?

@chr-hertel
Copy link
Member

alright, let's go - will add some comments on #254 as well - building on top of this i guess.

OskarStark added a commit that referenced this pull request Sep 27, 2025
@OskarStark
feature #683 [AI Bundle] Rename ai:chat command to ai:agent:call …
d21ada7 
…(OskarStark)

This PR was merged into the main branch.

Discussion
----------

[AI Bundle] Rename `ai:chat` command to `ai:agent:call`

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Docs?         | no
| Issues        | Follows #395
| License       | MIT

I think we can have ai:chat command soon after #675

Commits
-------

ec7018f Rename ai:chat command to ai:agent:call with backward compatibility
@Guikingone
Copy link
Contributor Author

@chr-hertel Yes, the idea is to start by splitting the chat, from that point, we can work on the storage part then handle the final implementation 🙂

@Guikingone Guikingone mentioned this pull request Sep 29, 2025
Open
@Guikingone
Copy link
Contributor Author

Guikingone commented Oct 2, 2025 •
edited
Loading

@OskarStark @chr-hertel Regarding this PR, I can't fix the tests / quality as the ai-chat repository is required, is there any solution to fix/validate them before merging or should we wait until its merged? 🤔

@Guikingone Guikingone force-pushed the refactor/split-chat branch from 71784a0 to 3f1dd48 Compare October 2, 2025 17:19
@OskarStark
Copy link
Contributor

I had the same problem for a new package in the brave tool PR.
I am fine merging as is and taking care of the CI afterwards, but immediately 👌🏻😝

@Guikingone
Copy link
Contributor Author

Ok, no problem 😅

Let me know when you have time to review the PR and merging it, on my side, most of the work is done, I can work on other PRs until you merge it.

@OskarStark
Copy link
Contributor

@fabpot we would need a new package here please

@fabpot
Copy link
Member

fabpot commented Oct 3, 2025

@OskarStark We need to merge the PR first :) Ping me when done.

@OskarStark
Copy link
Contributor

Thank you @Guikingone.

@OskarStark OskarStark merged commit 1c37e87 into symfony:main Oct 3, 2025
9 of 15 checks passed
@OskarStark
Copy link
Contributor

@fabpot done ✅

@Guikingone please keep an 👁️ on the CI, thanks 🙏

@OskarStark OskarStark mentioned this pull request Oct 3, 2025
Open
@fabpot
Copy link
Member

fabpot commented Oct 4, 2025

New package created and published on Packagist: https://packagist.org/packages/symfony/ai-chat

@OskarStark
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

Assignees
No one assigned
Labels
Feature New feature Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Guikingone @OskarStark @chr-hertel @fabpot @carsonbot