[Chat] Introduce a new component #675
Conversation
Guikingone
changed the title
Guikingone
force-pushed
the
refactor/split-chat
branch
from
3e28571 to
419e46a
Compare
|
I like having a new component for this |
|
alright, let's go - will add some comments on #254 as well - building on top of this i guess. |
…(OskarStark) This PR was merged into the main branch. Discussion ---------- [AI Bundle] Rename `ai:chat` command to `ai:agent:call` | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | Follows #395 | License | MIT I think we can have ai:chat command soon after #675 Commits ------- ec7018f Rename ai:chat command to ai:agent:call with backward compatibility
|
@chr-hertel Yes, the idea is to start by splitting the chat, from that point, we can work on the storage part then handle the final implementation 🙂 |
Guikingone
force-pushed
the
refactor/split-chat
branch
from
ae3c575 to
32f5459
Compare
Guikingone
force-pushed
the
refactor/split-chat
branch
from
3818004 to
71784a0
Compare
|
@OskarStark @chr-hertel Regarding this PR, I can't fix the tests / quality as the |
Guikingone
force-pushed
the
refactor/split-chat
branch
from
71784a0 to
3f1dd48
Compare
|
I had the same problem for a new package in the brave tool PR. |
|
Ok, no problem 😅 Let me know when you have time to review the PR and merging it, on my side, most of the work is done, I can work on other PRs until you merge it. |
|
@fabpot we would need a new package here please |
|
@OskarStark We need to merge the PR first :) Ping me when done. |
|
Thank you @Guikingone. |
|
@fabpot done ✅ @Guikingone please keep an 👁️ on the CI, thanks 🙏 |
|
New package created and published on Packagist: https://packagist.org/packages/symfony/ai-chat |
|
Thanks |
Hi 👋🏻
Ok, time to tackle the big work on the #254 issue, the current structure doesn't allows to introduce new stores neither handling the storage of messages, mainly due to the fact that we can't intervene in the agent component without breaking the SRP of it.
This PR aims to split the
Chatinto a new component and ease the work on storing messages (with a new component, we can easily add storages here rather than in theagentcomponent), plus, it helps splitting the responsibilities inside the initiative as we should be allowed to start new agents without relying on any chats.This PR is a draft, feel free to open debates about it 😄