[Agent] Passing filtered tools option for internal agent calls #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzwilding
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
changed the title
franzwilding
changed the title
|
Hey, okay, sounds fishy, are you referring to an agent using a different agent as a tool or what is an "internal agent"? |
|
No, just regular tool calling. Once, one model does not successfully run, the inner agent->call is triggered and at this time, the tools are already resolved. |
|
@chr-hertel I think this only happens, if we have an event without an result. In this case, the AgentProcessor will call the agent again: |
…anzwilding/symfony-ai into fix/agent-tool-option-passing
# Conflicts: # src/agent/src/Toolbox/AgentProcessor.php
…anzwilding/symfony-ai into fix/agent-tool-option-passing
|
Do you have a way how I could reproduce this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing agent options to an internal agent call, the tools array is already resolved and is no longer just an array of strings. As a result, the input processor no longer filters the available agent tools. I’m not sure if this behavior is intentional, but in my case it causes issues: with each internal call, all tools suddenly become available, which confuses the model.