[Platform] Rename to DeferredResult and explicit contract instead of closure
#745
+135
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
refactor-result-promise
branch
from
9a87f20 to
c0a46b0
Compare
chr-hertel
force-pushed
the
refactor-result-promise
branch
2 times, most recently
from
dd8cd4d to
cf2be76
Compare
chr-hertel
force-pushed
the
refactor-result-promise
branch
from
cf2be76 to
503ac87
Compare
|
ResultHandle is also nice |
OskarStark
changed the title
DeferredResult and explicit contract instead of closure
OskarStark
approved these changes
Oct 7, 2025
|
Thank you @chr-hertel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResultPromisetoDeferredResultsince the interface is not really promise-like\ClosurewithResultConverterInterfacein constructorAlternative names
ResultFactory=> is it a factory?ResultBuilder=> is it a builder?LazyResult=> would expect the same interface as the ResultResultProxy=> would expect the same interface as the ResultWrappedResult=> i like wrapsResultContainer=> might confuse with the containerResultHandle=> ?