[Chat] Fix Doctrine DBAL message store #967
Conversation
xprojects-de
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
changed the title
|
I don't know why the Fabbot test is failing. It should be |
|
You can ignore this check. @Guikingone friendly ping |
|
Ah yes, I'm facing the same error locally on an existing database, I missed this part during tests 😓 |
| $schemaManager = $this->dbalConnection->createSchemaManager(); | ||
| $schema = $schemaManager->introspectSchema(); | ||
|
|
||
| if ($schema->hasTable($this->tableName)) { |
There was a problem hiding this comment.
The check could also be omitted. Then it would be possible to adjust the table.
There was a problem hiding this comment.
Bu if the table already exist, you're not supposed to add it again / alter it? 🤔
if would require to being able to passe extra fields during setup() calls, for now, it's not supported 🤔
There was a problem hiding this comment.
Yes, that would be exactly my use case :-) I just wanted to do it in two steps and fix the bug first.
It would be really nice if you could specify additional fields in the setup... I can gladly update the program so that's possible too...
There was a problem hiding this comment.
But I think the structure isn't quite there yet, since you would also have to adjust the load and save functions.
OskarStark
changed the title
|
rebase to fix lowest build |
|
The rebase was wrong |
xprojects-de
force-pushed
the
feature/fix-DoctrineDbalMessageStore
branch
from
25bd7d9 to
be6ecf9
Compare
|
oh yes sorry, i did a reflog. now it should be ok :-) |
4 participants
If the store is applied to a database that already contains other tables, the schema will not be defined correctly. The existing tables will be defined using a CREATE statement, which will result in an error. The pull request respects the existing structure, including the existing tables, and cleanly adds the new table.