[flatpickr] Fix flatpickr calendar buttons and localization #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is the icon still a trigger to open the flatpickr picker ? |
No, the button does nothing that's why I opted to remove the button and make the calendar icon the same as the tags icon The flatpickr calendar opens when the input field gets focus or is clicked. |
|
I think the intent was that the button would also trigger the picker (see the |
|
Hmm, I see. It may take some time until I get to that. |
rosier
force-pushed
the
bs5-form-fields
branch
2 times, most recently
from
43a7cc6 to
31840dc
Compare
rosier
changed the title
rosier
force-pushed
the
bs5-form-fields
branch
from
31840dc to
576ca48
Compare
rosier
changed the title
rosier
force-pushed
the
bs5-form-fields
branch
from
576ca48 to
584946e
Compare
rosier
force-pushed
the
bs5-form-fields
branch
from
584946e to
5cc4aef
Compare
|
I did add a toggle and a clear button |
|
Jan, thanks for fixing this and for the effort you put on it 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the alignment of the input fields and the add-ons