Skip to content

Commit 601f2c5

Browse files
Merge branch '3.3' into 3.4
* 3.3: [2.7] Fix issues found by PHPStan Add php_unit_dedicate_assert to PHPCS [WebProfilerBundle] Let fetch() cast URL to string improve FormType::getType exception message details [Intl] Update ICU data to 60.2 [Console] fix a bug when you are passing a default value and passing -n would ouput the index
2 parents 5f81907 + 2fadb1d commit 601f2c5

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

Tests/Compiler/RegisterEnvVarProcessorsPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testSimpleProcessor()
2626
(new RegisterEnvVarProcessorsPass())->process($container);
2727

2828
$this->assertTrue($container->has('container.env_var_processors_locator'));
29-
$this->assertInstanceof(SimpleProcessor::class, $container->get('container.env_var_processors_locator')->get('foo'));
29+
$this->assertInstanceOf(SimpleProcessor::class, $container->get('container.env_var_processors_locator')->get('foo'));
3030

3131
$expected = array(
3232
'foo' => array('string'),

Tests/Compiler/ResolveInstanceofConditionalsPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function testProcess()
3232
$parent = 'instanceof.'.parent::class.'.0.foo';
3333
$def = $container->getDefinition('foo');
3434
$this->assertEmpty($def->getInstanceofConditionals());
35-
$this->assertInstanceof(ChildDefinition::class, $def);
35+
$this->assertInstanceOf(ChildDefinition::class, $def);
3636
$this->assertTrue($def->isAutowired());
3737
$this->assertSame($parent, $def->getParent());
3838
$this->assertSame(array('tag' => array(array()), 'baz' => array(array('attr' => 123))), $def->getTags());

Tests/ContainerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,7 @@ class ProjectServiceContainer extends Container
556556
public $__foo_bar;
557557
public $__foo_baz;
558558
public $__internal;
559+
protected $privates;
559560
protected $methodMap = array(
560561
'internal' => 'getInternalService',
561562
'bar' => 'getBarService',

0 commit comments

Comments
 (0)