Skip to content

Conversation

wuchen90
Copy link
Contributor

For those who doesn't want the package.json synchronization, this PR offers to opt-out this behavior by setting the config below in extra section of composer.json:

{
  "extra": {
    "symfony/flex": {
      "synchronize_package_json": false
    }
  }
}

fix #1017

@wuchen90 wuchen90 force-pushed the skip-package-json-sync branch from 9b8e4cb to 6a726fa Compare November 29, 2024 17:48
Copy link
Contributor

@skmedix skmedix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better if it logs what exactly has been skipped?

@wuchen90
Copy link
Contributor Author

Perhaps it would be better if it logs what exactly has been skipped?

@skmedix Currently it already outputs this <info>Skip synchronizing package.json with PHP packages</>. What kind of logs do you have in mind?

Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also need this option 👍

Copy link
Contributor

@skmedix skmedix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's good enough, so LGTM

@fabpot fabpot changed the base branch from 2.x to 1.x March 3, 2025 07:50
@fabpot fabpot force-pushed the skip-package-json-sync branch from 6a726fa to 791e814 Compare March 3, 2025 07:50
@fabpot
Copy link
Member

fabpot commented Mar 3, 2025

Thank you @wuchen90.

@fabpot fabpot merged commit 5cc9859 into symfony:1.x Mar 3, 2025
4 of 7 checks passed
@wuchen90 wuchen90 deleted the skip-package-json-sync branch March 3, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make packages.json synchronization optional

5 participants