feat: Make DockerComposeConfigurator compatible with "false" string#1061
Merged
fabpot merged 1 commit intosymfony:2.xfrom Jul 9, 2025
Merged
feat: Make DockerComposeConfigurator compatible with "false" string#1061fabpot merged 1 commit intosymfony:2.xfrom
fabpot merged 1 commit intosymfony:2.xfrom
Conversation
stof
approved these changes
Jul 8, 2025
dunglas
approved these changes
Jul 8, 2025
maxhelias
approved these changes
Jul 8, 2025
Member
|
Thank you @jawira. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1060
With this MR
DockerComposeConfiguratorwill recognize"false"string a proper boolean.I use
filter_varfunction, I think this is a good solution because it requires only a single method call to fix the issue.With
filter_varfunction:trueas well.false.Additionally this function is already used in the same method some lines below:
flex/src/Configurator/DockerComposeConfigurator.php
Lines 115 to 117 in 423c36e