-
-
Notifications
You must be signed in to change notification settings - Fork 194
Resolve directories for copy from recipe in update case #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve directories for copy from recipe in update case #950
Conversation
dfd3445 to
7392a69
Compare
|
This should add tests covering this behavior (in CopyFromRecipeConfiguratorTest) to prevent regressions. |
cdf1300 to
8ba864e
Compare
|
the 7.4 fails because of packagist woofoo with composer 1 |
| $recipeUpdate, | ||
| [ | ||
| 'root/' => '', | ||
| 'symfony8config/' => '%CONFIG_DIR%/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the recipe using symfony8config and mapping it to the usual config dir named config is not at all the use case that you want to solve (it is exactly the opposite use case). I suggest making the test cover the intended use case instead, as that's the use case for which we want to prevent regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to test, when the path is empty or you mapped to it %SOME-VAR%
I can remove it if you want. mapping config to %CONFIG_DIR% makes no difference
|
It will be backported when merged I think automatically |
8ba864e to
ee3a0d5
Compare
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this fix.
PR targeting 2.x as 1.x is not maintained anymore.
|
Thank you @shyim. |
The update case of
CopyFromRecipeConfiguratordoes not respect the folders in the config.https://symfony.com/doc/current/setup/flex.html#customizing-flex-paths