Merge branch '4.4' into 5.3

derrabus · derrabus · commit 40fcc28fb70c · 2021-08-04T23:20:46.000+02:00
* 4.4:
  Fix return types for PHP 8.1
diff --git a/Button.php b/Button.php
@@ -51,6 +51,7 @@ public function __construct(FormConfigInterface $config)
      *
      * @return bool Always returns false
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return false;
@@ -67,6 +68,7 @@ public function offsetExists($offset)
      *
      * @throws BadMethodCallException
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         throw new BadMethodCallException('Buttons cannot have children.');
@@ -84,6 +86,7 @@ public function offsetGet($offset)
      *
      * @throws BadMethodCallException
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         throw new BadMethodCallException('Buttons cannot have children.');
@@ -100,6 +103,7 @@ public function offsetSet($offset, $value)
      *
      * @throws BadMethodCallException
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         throw new BadMethodCallException('Buttons cannot have children.');
@@ -430,6 +434,7 @@ public function createView(FormView $parent = null)
      *
      * @return int Always returns 0
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return 0;
@@ -440,6 +445,7 @@ public function count()
      *
      * @return \EmptyIterator Always returns an empty iterator
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \EmptyIterator();
diff --git a/ButtonBuilder.php b/ButtonBuilder.php
@@ -715,6 +715,7 @@ public function getIsEmptyCallback(): ?callable
      *
      * @return int Always returns 0
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return 0;
@@ -725,6 +726,7 @@ public function count()
      *
      * @return \EmptyIterator Always returns an empty iterator
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \EmptyIterator();
diff --git a/ChoiceList/View/ChoiceGroupView.php b/ChoiceList/View/ChoiceGroupView.php
@@ -35,8 +35,9 @@ public function __construct(string $label, array $choices = [])
     /**
      * {@inheritdoc}
      *
-     * @return self[]|ChoiceView[]
+     * @return \Traversable<ChoiceGroupView|ChoiceView>
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator($this->choices);
diff --git a/Extension/Validator/ViolationMapper/ViolationPath.php b/Extension/Validator/ViolationMapper/ViolationPath.php
@@ -221,6 +221,7 @@ public function mapsForm(int $index)
      *
      * @return ViolationPathIterator
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new ViolationPathIterator($this);
diff --git a/Form.php b/Form.php
@@ -965,6 +965,7 @@ public function get(string $name)
      *
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($name)
     {
         return $this->has($name);
@@ -979,6 +980,7 @@ public function offsetExists($name)
      *
      * @throws OutOfBoundsException if the named child does not exist
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($name)
     {
         return $this->get($name);
@@ -997,6 +999,7 @@ public function offsetGet($name)
      *
      * @see self::add()
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($name, $child)
     {
         $this->add($child);
@@ -1011,6 +1014,7 @@ public function offsetSet($name, $child)
      *
      * @throws AlreadySubmittedException if the form has already been submitted
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($name)
     {
         $this->remove($name);
@@ -1021,6 +1025,7 @@ public function offsetUnset($name)
      *
      * @return \Traversable<FormInterface>
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return $this->children;
@@ -1031,6 +1036,7 @@ public function getIterator()
      *
      * @return int The number of embedded form children
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return \count($this->children);
diff --git a/FormBuilder.php b/FormBuilder.php
@@ -161,6 +161,7 @@ public function all()
     /**
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         if ($this->locked) {
@@ -215,6 +216,7 @@ public function getForm()
      *
      * @return FormBuilderInterface[]|\Traversable
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         if ($this->locked) {
diff --git a/FormErrorIterator.php b/FormErrorIterator.php
@@ -93,6 +93,7 @@ public function getForm()
      *
      * @return FormError|self An error or an iterator containing nested errors
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return current($this->errors);
@@ -101,6 +102,7 @@ public function current()
     /**
      * Advances the iterator to the next position.
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         next($this->errors);
@@ -111,6 +113,7 @@ public function next()
      *
      * @return int The 0-indexed position
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return key($this->errors);
@@ -121,6 +124,7 @@ public function key()
      *
      * @return bool Whether the iterator is valid
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         return null !== key($this->errors);
@@ -132,6 +136,7 @@ public function valid()
      * This method detects if errors have been added to the form since the
      * construction of the iterator.
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         reset($this->errors);
@@ -144,6 +149,7 @@ public function rewind()
      *
      * @return bool Whether that position exists
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($position)
     {
         return isset($this->errors[$position]);
@@ -158,6 +164,7 @@ public function offsetExists($position)
      *
      * @throws OutOfBoundsException If the given position does not exist
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($position)
     {
         if (!isset($this->errors[$position])) {
@@ -174,6 +181,7 @@ public function offsetGet($position)
      *
      * @throws BadMethodCallException
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($position, $value)
     {
         throw new BadMethodCallException('The iterator doesn\'t support modification of elements.');
@@ -186,6 +194,7 @@ public function offsetSet($position, $value)
      *
      * @throws BadMethodCallException
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($position)
     {
         throw new BadMethodCallException('The iterator doesn\'t support modification of elements.');
@@ -197,6 +206,7 @@ public function offsetUnset($position)
      *
      * @return bool Whether the current element is an instance of this class
      */
+    #[\ReturnTypeWillChange]
     public function hasChildren()
     {
         return current($this->errors) instanceof self;
@@ -207,6 +217,7 @@ public function hasChildren()
      *
      * @return self
      */
+    #[\ReturnTypeWillChange]
     public function getChildren()
     {
         return current($this->errors);
@@ -229,6 +240,7 @@ public function getChildren()
      *
      * @return int The number of iterated elements
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return \count($this->errors);
@@ -243,6 +255,7 @@ public function count()
      *
      * @throws OutOfBoundsException If the position is invalid
      */
+    #[\ReturnTypeWillChange]
     public function seek($position)
     {
         if (!isset($this->errors[$position])) {
diff --git a/FormView.php b/FormView.php
@@ -108,6 +108,7 @@ public function setMethodRendered()
      *
      * @return self The child view
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($name)
     {
         return $this->children[$name];
@@ -120,6 +121,7 @@ public function offsetGet($name)
      *
      * @return bool Whether the child view exists
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($name)
     {
         return isset($this->children[$name]);
@@ -132,6 +134,7 @@ public function offsetExists($name)
      *
      * @throws BadMethodCallException always as setting a child by name is not allowed
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($name, $value)
     {
         throw new BadMethodCallException('Not supported.');
@@ -144,6 +147,7 @@ public function offsetSet($name, $value)
      *
      * @return void
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($name)
     {
         unset($this->children[$name]);
@@ -154,6 +158,7 @@ public function offsetUnset($name)
      *
      * @return \ArrayIterator<string, FormView> The iterator
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator($this->children);
@@ -164,6 +169,7 @@ public function getIterator()
      *
      * @return int The number of children views
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return \count($this->children);
diff --git a/Tests/Fixtures/CustomArrayObject.php b/Tests/Fixtures/CustomArrayObject.php
@@ -29,12 +29,17 @@ public function offsetExists($offset): bool
         return \array_key_exists($offset, $this->array);
     }
 
+    /**
+     * @param mixed $offset
+     * @return mixed
+     */
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return $this->array[$offset];
     }
 
-    public function offsetSet($offset, $value)
+    public function offsetSet($offset, $value): void
     {
         if (null === $offset) {
             $this->array[] = $value;
@@ -43,7 +48,7 @@ public function offsetSet($offset, $value)
         }
     }
 
-    public function offsetUnset($offset)
+    public function offsetUnset($offset): void
     {
         unset($this->array[$offset]);
     }
@@ -73,7 +78,7 @@ public function __unserialize(array $data): void
         $this->array = $data;
     }
 
-    public function unserialize($serialized)
+    public function unserialize($serialized): void
     {
         $this->__unserialize((array) unserialize((string) $serialized));
     }
diff --git a/Util/InheritDataAwareIterator.php b/Util/InheritDataAwareIterator.php
@@ -30,6 +30,7 @@ class InheritDataAwareIterator extends \IteratorIterator implements \RecursiveIt
      *
      * @return static
      */
+    #[\ReturnTypeWillChange]
     public function getChildren()
     {
         return new static($this->current());
@@ -38,6 +39,7 @@ public function getChildren()
     /**
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function hasChildren()
     {
         return (bool) $this->current()->getConfig()->getInheritData();
diff --git a/Util/OrderedHashMap.php b/Util/OrderedHashMap.php
@@ -101,6 +101,7 @@ public function __construct(array $elements = [])
     /**
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($key)
     {
         return isset($this->elements[$key]);
@@ -111,6 +112,7 @@ public function offsetExists($key)
      *
      * @return mixed
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($key)
     {
         if (!isset($this->elements[$key])) {
@@ -125,6 +127,7 @@ public function offsetGet($key)
      *
      * @return void
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($key, $value)
     {
         if (null === $key || !isset($this->elements[$key])) {
@@ -148,6 +151,7 @@ public function offsetSet($key, $value)
      *
      * @return void
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($key)
     {
         if (false !== ($position = array_search((string) $key, $this->orderedKeys))) {
@@ -165,6 +169,7 @@ public function offsetUnset($key)
     /**
      * @return \Traversable
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new OrderedHashMapIterator($this->elements, $this->orderedKeys, $this->managedCursors);
@@ -173,6 +178,7 @@ public function getIterator()
     /**
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return \count($this->elements);
diff --git a/Util/OrderedHashMapIterator.php b/Util/OrderedHashMapIterator.php

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ public function __construct(FormConfigInterface $config)`
`51`	`51`	`*`
`52`	`52`	`* @return bool Always returns false`
`53`	`53`	`*/`
	`54`	`+ #[\ReturnTypeWillChange]`
`54`	`55`	`public function offsetExists($offset)`
`55`	`56`	`{`
`56`	`57`	`return false;`
`@@ -67,6 +68,7 @@ public function offsetExists($offset)`
`67`	`68`	`*`
`68`	`69`	`* @throws BadMethodCallException`
`69`	`70`	`*/`
	`71`	`+ #[\ReturnTypeWillChange]`
`70`	`72`	`public function offsetGet($offset)`
`71`	`73`	`{`
`72`	`74`	`throw new BadMethodCallException('Buttons cannot have children.');`
`@@ -84,6 +86,7 @@ public function offsetGet($offset)`
`84`	`86`	`*`
`85`	`87`	`* @throws BadMethodCallException`
`86`	`88`	`*/`
	`89`	`+ #[\ReturnTypeWillChange]`
`87`	`90`	`public function offsetSet($offset, $value)`
`88`	`91`	`{`
`89`	`92`	`throw new BadMethodCallException('Buttons cannot have children.');`
`@@ -100,6 +103,7 @@ public function offsetSet($offset, $value)`
`100`	`103`	`*`
`101`	`104`	`* @throws BadMethodCallException`
`102`	`105`	`*/`
	`106`	`+ #[\ReturnTypeWillChange]`
`103`	`107`	`public function offsetUnset($offset)`
`104`	`108`	`{`
`105`	`109`	`throw new BadMethodCallException('Buttons cannot have children.');`
`@@ -430,6 +434,7 @@ public function createView(FormView $parent = null)`
`430`	`434`	`*`
`431`	`435`	`* @return int Always returns 0`
`432`	`436`	`*/`
	`437`	`+ #[\ReturnTypeWillChange]`
`433`	`438`	`public function count()`
`434`	`439`	`{`
`435`	`440`	`return 0;`
`@@ -440,6 +445,7 @@ public function count()`
`440`	`445`	`*`
`441`	`446`	`* @return \EmptyIterator Always returns an empty iterator`
`442`	`447`	`*/`
	`448`	`+ #[\ReturnTypeWillChange]`
`443`	`449`	`public function getIterator()`
`444`	`450`	`{`
`445`	`451`	`return new \EmptyIterator();`
Original file line number	Diff line number	Diff line change
`@@ -715,6 +715,7 @@ public function getIsEmptyCallback(): ?callable`
`715`	`715`	`*`
`716`	`716`	`* @return int Always returns 0`
`717`	`717`	`*/`
	`718`	`+ #[\ReturnTypeWillChange]`
`718`	`719`	`public function count()`
`719`	`720`	`{`
`720`	`721`	`return 0;`
`@@ -725,6 +726,7 @@ public function count()`
`725`	`726`	`*`
`726`	`727`	`* @return \EmptyIterator Always returns an empty iterator`
`727`	`728`	`*/`
	`729`	`+ #[\ReturnTypeWillChange]`
`728`	`730`	`public function getIterator()`
`729`	`731`	`{`
`730`	`732`	`return new \EmptyIterator();`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,9 @@ public function __construct(string $label, array $choices = [])`
`35`	`35`	`/**`
`36`	`36`	`* {@inheritdoc}`
`37`	`37`	`*`
`38`		`- * @return self[]\|ChoiceView[]`
	`38`	`+ * @return \Traversable<ChoiceGroupView\|ChoiceView>`
`39`	`39`	`*/`
	`40`	`+ #[\ReturnTypeWillChange]`
`40`	`41`	`public function getIterator()`
`41`	`42`	`{`
`42`	`43`	`return new \ArrayIterator($this->choices);`
Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,7 @@ public function mapsForm(int $index)`
`221`	`221`	`*`
`222`	`222`	`* @return ViolationPathIterator`
`223`	`223`	`*/`
	`224`	`+ #[\ReturnTypeWillChange]`
`224`	`225`	`public function getIterator()`
`225`	`226`	`{`
`226`	`227`	`return new ViolationPathIterator($this);`
Original file line number	Diff line number	Diff line change
`@@ -965,6 +965,7 @@ public function get(string $name)`
`965`	`965`	`*`
`966`	`966`	`* @return bool`
`967`	`967`	`*/`
	`968`	`+ #[\ReturnTypeWillChange]`
`968`	`969`	`public function offsetExists($name)`
`969`	`970`	`{`
`970`	`971`	`return $this->has($name);`
`@@ -979,6 +980,7 @@ public function offsetExists($name)`
`979`	`980`	`*`
`980`	`981`	`* @throws OutOfBoundsException if the named child does not exist`
`981`	`982`	`*/`
	`983`	`+ #[\ReturnTypeWillChange]`
`982`	`984`	`public function offsetGet($name)`
`983`	`985`	`{`
`984`	`986`	`return $this->get($name);`
`@@ -997,6 +999,7 @@ public function offsetGet($name)`
`997`	`999`	`*`
`998`	`1000`	`* @see self::add()`
`999`	`1001`	`*/`
	`1002`	`+ #[\ReturnTypeWillChange]`
`1000`	`1003`	`public function offsetSet($name, $child)`
`1001`	`1004`	`{`
`1002`	`1005`	`$this->add($child);`
`@@ -1011,6 +1014,7 @@ public function offsetSet($name, $child)`
`1011`	`1014`	`*`
`1012`	`1015`	`* @throws AlreadySubmittedException if the form has already been submitted`
`1013`	`1016`	`*/`
	`1017`	`+ #[\ReturnTypeWillChange]`
`1014`	`1018`	`public function offsetUnset($name)`
`1015`	`1019`	`{`
`1016`	`1020`	`$this->remove($name);`
`@@ -1021,6 +1025,7 @@ public function offsetUnset($name)`
`1021`	`1025`	`*`
`1022`	`1026`	`* @return \Traversable<FormInterface>`
`1023`	`1027`	`*/`
	`1028`	`+ #[\ReturnTypeWillChange]`
`1024`	`1029`	`public function getIterator()`
`1025`	`1030`	`{`
`1026`	`1031`	`return $this->children;`
`@@ -1031,6 +1036,7 @@ public function getIterator()`
`1031`	`1036`	`*`
`1032`	`1037`	`* @return int The number of embedded form children`
`1033`	`1038`	`*/`
	`1039`	`+ #[\ReturnTypeWillChange]`
`1034`	`1040`	`public function count()`
`1035`	`1041`	`{`
`1036`	`1042`	`return \count($this->children);`
Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,7 @@ public function all()`
`161`	`161`	`/**`
`162`	`162`	`* @return int`
`163`	`163`	`*/`
	`164`	`+ #[\ReturnTypeWillChange]`
`164`	`165`	`public function count()`
`165`	`166`	`{`
`166`	`167`	`if ($this->locked) {`
`@@ -215,6 +216,7 @@ public function getForm()`
`215`	`216`	`*`
`216`	`217`	`* @return FormBuilderInterface[]\|\Traversable`
`217`	`218`	`*/`
	`219`	`+ #[\ReturnTypeWillChange]`
`218`	`220`	`public function getIterator()`
`219`	`221`	`{`
`220`	`222`	`if ($this->locked) {`
Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ public function getForm()`
`93`	`93`	`*`
`94`	`94`	`* @return FormError\|self An error or an iterator containing nested errors`
`95`	`95`	`*/`
	`96`	`+ #[\ReturnTypeWillChange]`
`96`	`97`	`public function current()`
`97`	`98`	`{`
`98`	`99`	`return current($this->errors);`
`@@ -101,6 +102,7 @@ public function current()`
`101`	`102`	`/**`
`102`	`103`	`* Advances the iterator to the next position.`
`103`	`104`	`*/`
	`105`	`+ #[\ReturnTypeWillChange]`
`104`	`106`	`public function next()`
`105`	`107`	`{`
`106`	`108`	`next($this->errors);`
`@@ -111,6 +113,7 @@ public function next()`
`111`	`113`	`*`
`112`	`114`	`* @return int The 0-indexed position`
`113`	`115`	`*/`
	`116`	`+ #[\ReturnTypeWillChange]`
`114`	`117`	`public function key()`
`115`	`118`	`{`
`116`	`119`	`return key($this->errors);`
`@@ -121,6 +124,7 @@ public function key()`
`121`	`124`	`*`
`122`	`125`	`* @return bool Whether the iterator is valid`
`123`	`126`	`*/`
	`127`	`+ #[\ReturnTypeWillChange]`
`124`	`128`	`public function valid()`
`125`	`129`	`{`
`126`	`130`	`return null !== key($this->errors);`
`@@ -132,6 +136,7 @@ public function valid()`
`132`	`136`	`* This method detects if errors have been added to the form since the`
`133`	`137`	`* construction of the iterator.`
`134`	`138`	`*/`
	`139`	`+ #[\ReturnTypeWillChange]`
`135`	`140`	`public function rewind()`
`136`	`141`	`{`
`137`	`142`	`reset($this->errors);`
`@@ -144,6 +149,7 @@ public function rewind()`
`144`	`149`	`*`
`145`	`150`	`* @return bool Whether that position exists`
`146`	`151`	`*/`
	`152`	`+ #[\ReturnTypeWillChange]`
`147`	`153`	`public function offsetExists($position)`
`148`	`154`	`{`
`149`	`155`	`return isset($this->errors[$position]);`
`@@ -158,6 +164,7 @@ public function offsetExists($position)`
`158`	`164`	`*`
`159`	`165`	`* @throws OutOfBoundsException If the given position does not exist`
`160`	`166`	`*/`
	`167`	`+ #[\ReturnTypeWillChange]`
`161`	`168`	`public function offsetGet($position)`
`162`	`169`	`{`
`163`	`170`	`if (!isset($this->errors[$position])) {`
`@@ -174,6 +181,7 @@ public function offsetGet($position)`
`174`	`181`	`*`
`175`	`182`	`* @throws BadMethodCallException`
`176`	`183`	`*/`
	`184`	`+ #[\ReturnTypeWillChange]`
`177`	`185`	`public function offsetSet($position, $value)`
`178`	`186`	`{`
`179`	`187`	`throw new BadMethodCallException('The iterator doesn\'t support modification of elements.');`
`@@ -186,6 +194,7 @@ public function offsetSet($position, $value)`
`186`	`194`	`*`
`187`	`195`	`* @throws BadMethodCallException`
`188`	`196`	`*/`
	`197`	`+ #[\ReturnTypeWillChange]`
`189`	`198`	`public function offsetUnset($position)`
`190`	`199`	`{`
`191`	`200`	`throw new BadMethodCallException('The iterator doesn\'t support modification of elements.');`
`@@ -197,6 +206,7 @@ public function offsetUnset($position)`
`197`	`206`	`*`
`198`	`207`	`* @return bool Whether the current element is an instance of this class`
`199`	`208`	`*/`
	`209`	`+ #[\ReturnTypeWillChange]`
`200`	`210`	`public function hasChildren()`
`201`	`211`	`{`
`202`	`212`	`return current($this->errors) instanceof self;`
`@@ -207,6 +217,7 @@ public function hasChildren()`
`207`	`217`	`*`
`208`	`218`	`* @return self`
`209`	`219`	`*/`
	`220`	`+ #[\ReturnTypeWillChange]`
`210`	`221`	`public function getChildren()`
`211`	`222`	`{`
`212`	`223`	`return current($this->errors);`
`@@ -229,6 +240,7 @@ public function getChildren()`
`229`	`240`	`*`
`230`	`241`	`* @return int The number of iterated elements`
`231`	`242`	`*/`
	`243`	`+ #[\ReturnTypeWillChange]`
`232`	`244`	`public function count()`
`233`	`245`	`{`
`234`	`246`	`return \count($this->errors);`
`@@ -243,6 +255,7 @@ public function count()`
`243`	`255`	`*`
`244`	`256`	`* @throws OutOfBoundsException If the position is invalid`
`245`	`257`	`*/`
	`258`	`+ #[\ReturnTypeWillChange]`
`246`	`259`	`public function seek($position)`
`247`	`260`	`{`
`248`	`261`	`if (!isset($this->errors[$position])) {`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ public function setMethodRendered()`
`108`	`108`	`*`
`109`	`109`	`* @return self The child view`
`110`	`110`	`*/`
	`111`	`+ #[\ReturnTypeWillChange]`
`111`	`112`	`public function offsetGet($name)`
`112`	`113`	`{`
`113`	`114`	`return $this->children[$name];`
`@@ -120,6 +121,7 @@ public function offsetGet($name)`
`120`	`121`	`*`
`121`	`122`	`* @return bool Whether the child view exists`
`122`	`123`	`*/`
	`124`	`+ #[\ReturnTypeWillChange]`
`123`	`125`	`public function offsetExists($name)`
`124`	`126`	`{`
`125`	`127`	`return isset($this->children[$name]);`
`@@ -132,6 +134,7 @@ public function offsetExists($name)`
`132`	`134`	`*`
`133`	`135`	`* @throws BadMethodCallException always as setting a child by name is not allowed`
`134`	`136`	`*/`
	`137`	`+ #[\ReturnTypeWillChange]`
`135`	`138`	`public function offsetSet($name, $value)`
`136`	`139`	`{`
`137`	`140`	`throw new BadMethodCallException('Not supported.');`
`@@ -144,6 +147,7 @@ public function offsetSet($name, $value)`
`144`	`147`	`*`
`145`	`148`	`* @return void`
`146`	`149`	`*/`
	`150`	`+ #[\ReturnTypeWillChange]`
`147`	`151`	`public function offsetUnset($name)`
`148`	`152`	`{`
`149`	`153`	`unset($this->children[$name]);`
`@@ -154,6 +158,7 @@ public function offsetUnset($name)`
`154`	`158`	`*`
`155`	`159`	`* @return \ArrayIterator<string, FormView> The iterator`
`156`	`160`	`*/`
	`161`	`+ #[\ReturnTypeWillChange]`
`157`	`162`	`public function getIterator()`
`158`	`163`	`{`
`159`	`164`	`return new \ArrayIterator($this->children);`
`@@ -164,6 +169,7 @@ public function getIterator()`
`164`	`169`	`*`
`165`	`170`	`* @return int The number of children views`
`166`	`171`	`*/`
	`172`	`+ #[\ReturnTypeWillChange]`
`167`	`173`	`public function count()`
`168`	`174`	`{`
`169`	`175`	`return \count($this->children);`
Original file line number	Diff line number	Diff line change
`@@ -29,12 +29,17 @@ public function offsetExists($offset): bool`
`29`	`29`	`return \array_key_exists($offset, $this->array);`
`30`	`30`	`}`
`31`	`31`
	`32`	`+ /**`
	`33`	`+ * @param mixed $offset`
	`34`	`+ * @return mixed`
	`35`	`+ */`
	`36`	`+ #[\ReturnTypeWillChange]`
`32`	`37`	`public function offsetGet($offset)`
`33`	`38`	`{`
`34`	`39`	`return $this->array[$offset];`
`35`	`40`	`}`
`36`	`41`
`37`		`- public function offsetSet($offset, $value)`
	`42`	`+ public function offsetSet($offset, $value): void`
`38`	`43`	`{`
`39`	`44`	`if (null === $offset) {`
`40`	`45`	`$this->array[] = $value;`
`@@ -43,7 +48,7 @@ public function offsetSet($offset, $value)`
`43`	`48`	`}`
`44`	`49`	`}`
`45`	`50`
`46`		`- public function offsetUnset($offset)`
	`51`	`+ public function offsetUnset($offset): void`
`47`	`52`	`{`
`48`	`53`	`unset($this->array[$offset]);`
`49`	`54`	`}`
`@@ -73,7 +78,7 @@ public function __unserialize(array $data): void`
`73`	`78`	`$this->array = $data;`
`74`	`79`	`}`
`75`	`80`
`76`		`- public function unserialize($serialized)`
	`81`	`+ public function unserialize($serialized): void`
`77`	`82`	`{`
`78`	`83`	`$this->__unserialize((array) unserialize((string) $serialized));`
`79`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ class InheritDataAwareIterator extends \IteratorIterator implements \RecursiveIt`
`30`	`30`	`*`
`31`	`31`	`* @return static`
`32`	`32`	`*/`
	`33`	`+ #[\ReturnTypeWillChange]`
`33`	`34`	`public function getChildren()`
`34`	`35`	`{`
`35`	`36`	`return new static($this->current());`
`@@ -38,6 +39,7 @@ public function getChildren()`
`38`	`39`	`/**`
`39`	`40`	`* @return bool`
`40`	`41`	`*/`
	`42`	`+ #[\ReturnTypeWillChange]`
`41`	`43`	`public function hasChildren()`
`42`	`44`	`{`
`43`	`45`	`return (bool) $this->current()->getConfig()->getInheritData();`