Remove some unneeded checks/tests

Author: nicolas-grekas

Extension/Core/DataTransformer/BaseDateTimeTransformer.php

@@ -13,7 +13,6 @@
 
 use Symfony\Component\Form\DataTransformerInterface;
 use Symfony\Component\Form\Exception\InvalidArgumentException;
-use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
 abstract class BaseDateTimeTransformer implements DataTransformerInterface
 {
@@ -33,19 +32,10 @@ abstract class BaseDateTimeTransformer implements DataTransformerInterface
      * @param string $inputTimezone  The name of the input timezone
      * @param string $outputTimezone The name of the output timezone
      *
-     * @throws UnexpectedTypeException  if a timezone is not a string
      * @throws InvalidArgumentException if a timezone is not valid
      */
     public function __construct(string $inputTimezone = null, string $outputTimezone = null)
     {
-        if (null !== $inputTimezone && !is_string($inputTimezone)) {
-            throw new UnexpectedTypeException($inputTimezone, 'string');
-        }
-
-        if (null !== $outputTimezone && !is_string($outputTimezone)) {
-            throw new UnexpectedTypeException($outputTimezone, 'string');
-        }
-
         $this->inputTimezone = $inputTimezone ?: date_default_timezone_get();
         $this->outputTimezone = $outputTimezone ?: date_default_timezone_get();
 

Extension/Core/DataTransformer/DateTimeToArrayTransformer.php

@@ -12,7 +12,6 @@
 namespace Symfony\Component\Form\Extension\Core\DataTransformer;
 
 use Symfony\Component\Form\Exception\TransformationFailedException;
-use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
 /**
  * Transforms between a normalized time and a localized time string/array.
@@ -31,8 +30,6 @@ class DateTimeToArrayTransformer extends BaseDateTimeTransformer
      * @param string $outputTimezone The output timezone
      * @param array  $fields         The date fields
      * @param bool   $pad            Whether to use padding
-     *
-     * @throws UnexpectedTypeException if a timezone is not a string
      */
     public function __construct(string $inputTimezone = null, string $outputTimezone = null, array $fields = null, bool $pad = false)
     {

Extension/Core/DataTransformer/DateTimeToStringTransformer.php

@@ -12,7 +12,6 @@
 namespace Symfony\Component\Form\Extension\Core\DataTransformer;
 
 use Symfony\Component\Form\Exception\TransformationFailedException;
-use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
 /**
  * Transforms between a date string and a DateTime object.
@@ -48,8 +47,6 @@ class DateTimeToStringTransformer extends BaseDateTimeTransformer
      * @param string $inputTimezone  The name of the input timezone
      * @param string $outputTimezone The name of the output timezone
      * @param string $format         The date format
-     *
-     * @throws UnexpectedTypeException if a timezone is not a string
      */
     public function __construct(string $inputTimezone = null, string $outputTimezone = null, string $format = 'Y-m-d H:i:s')
     {

Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php

@@ -306,22 +306,6 @@ public function testReverseTransformWrapsIntlErrors()
         $transformer->reverseTransform('12345');
     }
 
-    /**
-     * @expectedException \TypeError
-     */
-    public function testValidateDateFormatOption()
-    {
-        new DateTimeToLocalizedStringTransformer(null, null, 'foobar');
-    }
-
-    /**
-     * @expectedException \TypeError
-     */
-    public function testValidateTimeFormatOption()
-    {
-        new DateTimeToLocalizedStringTransformer(null, null, null, 'foobar');
-    }
-
     /**
      * @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
      */