[HttpClient] fix HttpClientDataCollector

nicolas-grekas · nicolas-grekas · commit 3873fae129b4 · 2019-11-16T09:45:13.000+01:00
diff --git a/DataCollector/HttpClientDataCollector.php b/DataCollector/HttpClientDataCollector.php
@@ -135,6 +135,7 @@ private function collectOnClient(TraceableHttpClient $client): array
 
             $debugInfo = array_diff_key($info, $baseInfo);
             $info = array_diff_key($info, $debugInfo) + ['debug_info' => $debugInfo];
+            unset($traces[$i]['info']); // break PHP reference used by TraceableHttpClient
             $traces[$i]['info'] = $this->cloneVar($info);
             $traces[$i]['options'] = $this->cloneVar($trace['options']);
         }

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ private function collectOnClient(TraceableHttpClient $client): array`
`135`	`135`
`136`	`136`	`$debugInfo = array_diff_key($info, $baseInfo);`
`137`	`137`	`$info = array_diff_key($info, $debugInfo) + ['debug_info' => $debugInfo];`
	`138`	`+ unset($traces[$i]['info']); // break PHP reference used by TraceableHttpClient`
`138`	`139`	`$traces[$i]['info'] = $this->cloneVar($info);`
`139`	`140`	`$traces[$i]['options'] = $this->cloneVar($trace['options']);`
`140`	`141`	`}`