minor #455 Minimizing test matrix + fixing tests (weaverryan)

This PR was squashed before being merged into the 1.0-dev branch (closes #455).

Discussion
----------

Minimizing test matrix + fixing tests

Trying to strike a balance between having a very robust test suite, and one that takes too long to execute & blocks jobs under the `symfony/` organization.

Commits
-------

6d75f13 Adding support for new ErrorHandler DebugClassLoader
cd4ec4e changing from RegistryInterface to ManagerRegistry - #454
e622635 adding mysql service
3ebce10 Slightly minimizing our test matrix to try to reduce burden on Travis

Author: weaverryan

.travis.yml

@@ -5,6 +5,9 @@ cache:
         - $HOME/.composer/cache/files
         - $HOME/symfony-bridge/.phpunit
 
+services:
+    - mysql
+
 env:
     global:
         - PHPUNIT_FLAGS="-v"
@@ -13,30 +16,14 @@ env:
 matrix:
     fast_finish: true
     include:
-        - php: 7.1
-        - php: 7.2
         - php: 7.3
         - php: 7.1
           env: MAKER_TEST_VERSION=stable-dev
         - php: 7.1
           env: MAKER_TEST_VERSION=dev
 
-# the following need to be refactored properly into allow_failures
-#        allow_failures:
-#        # low deps is still a WIP
-#        - php: 7.1
-#          env: deps=low
-#          # Dev-master is allowed to fail.
-#        - env: STABILITY="dev"
-
 before_install:
-    - if ! [ -z "$STABILITY" ]; then composer config minimum-stability ${STABILITY}; fi;
-    - |
-      if [[ $deps = low ]]; then
-          composer update --prefer-lowest
-      else
-          composer update
-      fi
+    - composer update
 
 install:
     - ./vendor/bin/simple-phpunit install

src/Test/MakerTestEnvironment.php

@@ -439,12 +439,16 @@ private function getTargetFlexVersion(): string
                     $version = $data['latest'];
                     $parts = explode('.', $version);
 
-                    return sprintf('%s.%s.x-dev', $parts[0], $parts[1]);
+                    $this->targetFlexVersion = sprintf('%s.%s.x-dev', $parts[0], $parts[1]);
+
+                    break;
                 case 'dev':
                     $version = $data['dev'];
                     $parts = explode('.', $version);
 
-                    return sprintf('%s.%s.x-dev', $parts[0], $parts[1]);
+                    $this->targetFlexVersion = sprintf('%s.%s.x-dev', $parts[0], $parts[1]);
+
+                    break;
                 default:
                     throw new \Exception('Invalid target version');
             }

src/Util/ComposerAutoloaderFinder.php

@@ -13,6 +13,7 @@
 
 use Composer\Autoload\ClassLoader;
 use Symfony\Component\Debug\DebugClassLoader;
+use Symfony\Component\ErrorHandler\DebugClassLoader as ErrorHandlerDebugClassLoader;
 
 /**
  * @internal
@@ -82,7 +83,9 @@ private function extractComposerClassLoader(array $autoloader)
             if ($autoloader[0] instanceof ClassLoader) {
                 return $autoloader[0];
             }
-            if ($autoloader[0] instanceof DebugClassLoader
+            if (
+                ($autoloader[0] instanceof DebugClassLoader
+                    || $autoloader[0] instanceof ErrorHandlerDebugClassLoader)
                 && \is_array($autoloader[0]->getClassLoader())
                 && $autoloader[0]->getClassLoader()[0] instanceof ClassLoader) {
                 return $autoloader[0]->getClassLoader()[0];

tests/Doctrine/fixtures/expected_xml/src/Repository/UserRepository.php

@@ -4,7 +4,7 @@
 
 use Symfony\Bundle\MakerBundle\Tests\tmp\current_project_xml\src\Entity\UserXml;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
-use Symfony\Bridge\Doctrine\RegistryInterface;
+use Doctrine\Common\Persistence\ManagerRegistry;
 
 /**
  * @method UserXml|null find($id, $lockMode = null, $lockVersion = null)
@@ -14,7 +14,7 @@
  */
 class UserRepository extends ServiceEntityRepository
 {
-    public function __construct(RegistryInterface $registry)
+    public function __construct(ManagerRegistry $registry)
     {
         parent::__construct($registry, UserXml::class);
     }

tests/Doctrine/fixtures/expected_xml/src/Repository/XOtherRepository.php

@@ -4,7 +4,7 @@
 
 use Symfony\Bundle\MakerBundle\Tests\tmp\current_project_xml\src\Entity\XOther;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
-use Symfony\Bridge\Doctrine\RegistryInterface;
+use Doctrine\Common\Persistence\ManagerRegistry;
 
 /**
  * @method XOther|null find($id, $lockMode = null, $lockVersion = null)
@@ -14,7 +14,7 @@
  */
 class XOtherRepository extends ServiceEntityRepository
 {
-    public function __construct(RegistryInterface $registry)
+    public function __construct(ManagerRegistry $registry)
     {
         parent::__construct($registry, XOther::class);
     }

tests/fixtures/MakeCrudRepository/src/Repository/SweetFoodRepository.php

@@ -4,7 +4,7 @@
 
 use App\Entity\SweetFood;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
-use Symfony\Bridge\Doctrine\RegistryInterface;
+use Doctrine\Common\Persistence\ManagerRegistry;
 
 /**
  * @method SweetFood|null find($id, $lockMode = null, $lockVersion = null)
@@ -14,7 +14,7 @@
  */
 class SweetFoodRepository extends ServiceEntityRepository
 {
-    public function __construct(RegistryInterface $registry)
+    public function __construct(ManagerRegistry $registry)
     {
         parent::__construct($registry, SweetFood::class);
     }