Skip to content

Conversation

@symfonyaml
Copy link
Contributor

Context

When we run tests from the ./tests/tmp/cache directory, the built PHPUnit path contains 2 slashes because the MakerTestRunner::getPath() method already prefix with a slash.

Example

                                                                    ⬇️
./tests/tmp/cache/maker_app_7e4ffd082daa1224b6cfdeae54f3e3b2_current//bin/phpunit

Fix

Remove the prefixed slash in bin/phpunit

@jrushlow jrushlow added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Sep 25, 2024
@jrushlow jrushlow added this to the v1.62.0 milestone Sep 25, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @symfonyaml

Test failures fixed upstream

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 27, 2024
@jrushlow jrushlow merged commit d86730d into symfony:main Sep 27, 2024
@symfonyaml symfonyaml deleted the patch-1 branch September 27, 2024 06:55
@jrushlow jrushlow mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants