Skip to content

Conversation

@Curryed
Copy link
Contributor

@Curryed Curryed commented Jan 14, 2025

See description in #1652

@kbond
Copy link
Member

kbond commented Jan 14, 2025

Thanks for digging into this @Curryed.

What about removing the @return docblock and just letting the UserInterface dictate? I typically never override docblocks from interfaces/abstract classes (unless required) but maybe I'm in the minority?

@Curryed Curryed force-pushed the fix/roles-are-not-a-list branch from d621686 to 507afc1 Compare January 15, 2025 08:01
@Curryed
Copy link
Contributor Author

Curryed commented Jan 15, 2025

Sure! If that's the way you usually go for 😁

I updated the it removing the @return :)

Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kbond kbond force-pushed the fix/roles-are-not-a-list branch from 507afc1 to 28da5e4 Compare April 25, 2025 17:39
@kbond
Copy link
Member

kbond commented Apr 25, 2025

Thank you @Curryed.

@kbond kbond merged commit 022d79e into symfony:1.x Apr 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants