Skip to content

Fix putting the class-opening bracket on its own line #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix putting the class-opening bracket on its own line #1656

merged 1 commit into from
Mar 26, 2025

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 15, 2025 •
edited
Loading

Without this change, eg make:controller generates the following. A PHP closing tag eats its CR in some cases.

final class TotoController extends AbstractController{

@kbond
Copy link
Member

kbond commented Mar 26, 2025

Thanks Nicolas.

@kbond kbond merged commit fa5c903 into symfony:main Mar 26, 2025
9 checks passed
@nicolas-grekas nicolas-grekas deleted the bracket-next-line branch July 29, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@smnandre smnandre smnandre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas @kbond @smnandre