Skip to content

Fix default param key in validator #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Fix default param key in validator #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/validator/Constraint.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<?= $class_data->getClassDeclaration(); ?>

{
public string $message = 'The string "{{ string }}" contains an illegal character: it can only contain letters or numbers.';
public string $message = 'The string "{{ value }}" contains an illegal character: it can only contain letters or numbers.';
Copy link
Member

@lyrixx lyrixx Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/symfony/maker-bundle/blob/main/templates/validator/Validator.tpl.php#L19


// You can use #[HasNamedArguments] to make some constraint options required.
// All configurable options must be passed to the constructor.
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/make-validator/expected/FooBar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#[\Attribute(\Attribute::TARGET_PROPERTY | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]
final class FooBar extends Constraint
{
public string $message = 'The string "{{ string }}" contains an illegal character: it can only contain letters or numbers.';
public string $message = 'The string "{{ value }}" contains an illegal character: it can only contain letters or numbers.';

// You can use #[HasNamedArguments] to make some constraint options required.
// All configurable options must be passed to the constructor.
Expand Down