[make:form] suffix with "Form" instead of "Type" #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
💯 |
Contributor
|
The same for me 👍 |
nebkam
reviewed
Apr 28, 2025
| $form['registration_form[agreeTerms]'] = true; | ||
| $client->submit($form); | ||
|
|
||
| dump($client->getResponse()); |
kbond
added a commit
that referenced
this pull request
Apr 28, 2025
This PR was merged into the 1.x branch. Discussion ---------- Remove errant `dump()` from test Fixes #1685 (comment) Commits ------- d436e00 Remove errant `dump()` from test
Member
|
See #1711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be controversial but I've always found the term "Type" confusing for your forms. For the purposes of what this maker creates, these are "Forms".
If there is agreement on this change, I'll fix up the tests.