Skip to content

Add enabled parameter in configuration #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add enabled parameter in configuration #482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4178171
Add enabled parameter in configuration
May 27, 2024
cdee309
Merge branch 'symfony:master' into master
Arkalo2 Jun 22, 2025
070613b
Update DependencyInjection/MonologExtension.php
Arkalo2 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,7 @@ public function getConfigTreeBuilder(): TreeBuilder
->end()
->end()
->scalarNode('id')->end() // service & rollbar
->scalarNode('enabled')->defaultTrue()->end()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it intended that this is not a booleanNode?

->scalarNode('priority')->defaultValue(0)->end()
->scalarNode('level')->defaultValue('DEBUG')->end()
->booleanNode('bubble')->defaultTrue()->end()
Expand Down
3 changes: 3 additions & 0 deletions DependencyInjection/MonologExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ public function load(array $configs, ContainerBuilder $container)
$handlers = [];

foreach ($config['handlers'] as $name => $handler) {
if(false === $handler['enabled']) {
continue;
}
$handlers[$handler['priority']][] = [
'id' => $this->buildHandler($container, $name, $handler),
'channels' => empty($handler['channels']) ? null : $handler['channels'],
Expand Down
43 changes: 43 additions & 0 deletions Tests/DependencyInjection/Compiler/LoggerChannelPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\LoggerChannelPass;
use Symfony\Bundle\MonologBundle\DependencyInjection\MonologExtension;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
Expand Down Expand Up @@ -232,6 +233,48 @@ private function getFunctionalContainer()

return $container;
}

public function testEnabledHandler()
{
$container = new ContainerBuilder();
$loader = new MonologExtension();

$config = [
'handlers' => [
'main' => [
'enabled' => true,
'type' => 'stream',
'path' => '%kernel.logs_dir%/%kernel.environment%.log',
'level' => 'debug',
],
],
];

$loader->load([$config], $container);

$this->assertTrue($container->hasDefinition('monolog.handler.main'));
}

public function testDisabledHandler()
{
$container = new ContainerBuilder();
$loader = new MonologExtension();

$config = [
'handlers' => [
'main' => [
'enabled' => false,
'type' => 'stream',
'path' => '%kernel.logs_dir%/%kernel.environment%.log',
'level' => 'debug',
],
],
];

$loader->load([$config], $container);

$this->assertFalse($container->hasDefinition('monolog.handler.main'));
}
}

class DummyService
Expand Down