Skip to content

Removing code smell with $$args #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

Removing code smell with $$args #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,8 @@ public function request(string $method, string $uri, array $parameters = [], arr
throw new \InvalidArgumentException('The history always change when using WebDriver.');
}

foreach (['parameters', 'files', 'server'] as $arg) {
if ([] !== $$arg) {
throw new \InvalidArgumentException(sprintf('The parameter "$%s" is not supported when using WebDriver.', $arg));
}
if ([] !== $parameters || [] !== $files || [] !== $server) {
throw new \InvalidArgumentException('The arguments $parameters, $files, and $server are not supported when using WebDriver.');
}

$this->get($uri);
Expand Down