Add get_*_handler polyfills
#521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fan2Shrek
commented
Mar 27, 2025
nicolas-grekas
approved these changes
Mar 31, 2025
nicolas-grekas
force-pushed
the
add-handler
branch
from
5b4fafe to
d791faa
Compare
|
Thank you @Fan2Shrek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the polyfill of newly implemented
get_error_handlerandget_exception_handler.I have created the default files for PHP 8.5 polyfills.
The tests are taken from php/php-src#17693, but some cannot be completed due to new PHP 8 syntax.
There are some issues with the error handler in the tests, I can't figure out why. If someone can help, that would be great! 😅 This seems to be related to the TestListenerTrait, I think.
RFC