-
-
Notifications
You must be signed in to change notification settings - Fork 663
Add mago formatter recipe #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zuruuh
wants to merge
5
commits into
symfony:main
Choose a base branch
from
Zuruuh:mago
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
95e161d
feat: add mago formatter default configuration
Zuruuh 7f3464c
fix: remove patch version from version specifier
Zuruuh 5b551b7
fix: Remove unsupported options for contrib recipes
Zuruuh eaf2c59
fix: typo in post-install.txt
Zuruuh 105673c
Added a comment about format config and enable linter symfony and php…
Zuruuh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
php_version = "8.2" | ||
|
||
[source] | ||
paths = [ | ||
"src/", | ||
"config/", | ||
"bin/", | ||
# "tests/", | ||
# "importmap.php", | ||
# "migrations/", | ||
] | ||
includes = ["vendor"] | ||
excludes = [] | ||
|
||
# See https://docs.rs/mago-formatter/latest/mago_formatter/settings/struct.FormatSettings.html | ||
[format] | ||
print_width = 120 | ||
tab_width = 4 | ||
use_tabs = false | ||
|
||
[linter] | ||
default_plugins = true | ||
plugins = ["symfony", "php-unit"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"copy-from-recipe": { | ||
"mago.toml": "mago.toml" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<bg=blue;fg=white> </> | ||
<bg=blue;fg=white> What's next? </> | ||
<bg=blue;fg=white> </> | ||
|
||
* <fg=blue>Review</> your <comment>mago.toml</> file: | ||
1. Set your exact <comment>php_version</> | ||
2. Update your <comment>source.paths</> as needed; | ||
3. (Optional) Enable the <comment>linter</> as well. | ||
|
||
* <fg=blue>Read</> the full the documentation at <comment>https://mago.carthage.software/#/getting-started/configuration</> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are indeed the defaults,
mago init
generates this just to make it obvious where formatting settings go, it could be removed, or commented out with a link to the formatter docs? ref: https://docs.rs/mago-formatter/latest/mago_formatter/settings/struct.FormatSettings.html