config: Add support of artprima/prometheus-metrics-bundle v1.21#1948
Open
Johnmeurt wants to merge 1 commit intosymfony:mainfrom
Open
config: Add support of artprima/prometheus-metrics-bundle v1.21#1948Johnmeurt wants to merge 1 commit intosymfony:mainfrom
Johnmeurt wants to merge 1 commit intosymfony:mainfrom
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. artprima/prometheus-metrics-bundle1.0 vs 1.14diff --git a/artprima/prometheus-metrics-bundle/1.0/config/packages/prometheus_metrics.yaml b/artprima/prometheus-metrics-bundle/1.14/config/packages/prometheus_metrics.yaml
index e3e12106..7347ea7c 100644
--- a/artprima/prometheus-metrics-bundle/1.0/config/packages/prometheus_metrics.yaml
+++ b/artprima/prometheus-metrics-bundle/1.14/config/packages/prometheus_metrics.yaml
@@ -1,6 +1,21 @@
artprima_prometheus_metrics:
namespace: myapp
- type: apcu
+ storage: '%env(PROM_METRICS_DSN)%'
+
ignored_routes:
- - prometheus_bundle_prometheus
- - _wdt
+ - prometheus_bundle_prometheus
+ - _wdt
+
+ # used to disable default application metrics
+ #disable_default_metrics: false
+
+ # Recommended to disable default metrics from promphp/prometheus_client_php
+ # see https://github.com/PromPHP/prometheus_client_php/issues/62
+ disable_default_promphp_metrics: true
+
+ # used to enable console metrics
+ #enable_console_metrics: false
+
+when@test:
+ artprima_prometheus_metrics:
+ storage: in_memory
diff --git a/artprima/prometheus-metrics-bundle/1.0/config/packages/test/prometheus_metrics.yaml b/artprima/prometheus-metrics-bundle/1.0/config/packages/test/prometheus_metrics.yaml
deleted file mode 100644
index 80ad98d1..00000000
--- a/artprima/prometheus-metrics-bundle/1.0/config/packages/test/prometheus_metrics.yaml
+++ /dev/null
@@ -1,2 +0,0 @@
-artprima_prometheus_metrics:
- type: in_memory
diff --git a/artprima/prometheus-metrics-bundle/1.0/manifest.json b/artprima/prometheus-metrics-bundle/1.14/manifest.json
index d10a6b70..a4ddefdc 100644
--- a/artprima/prometheus-metrics-bundle/1.0/manifest.json
+++ b/artprima/prometheus-metrics-bundle/1.14/manifest.json
@@ -4,5 +4,8 @@
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
+ },
+ "env": {
+ "PROM_METRICS_DSN": "apcu"
}
}1.14 vs 1.21diff --git a/artprima/prometheus-metrics-bundle/1.14/config/routes/metrics.yaml b/artprima/prometheus-metrics-bundle/1.21/config/routes/metrics.yaml
index fa30eee0..24283f2d 100644
--- a/artprima/prometheus-metrics-bundle/1.14/config/routes/metrics.yaml
+++ b/artprima/prometheus-metrics-bundle/1.21/config/routes/metrics.yaml
@@ -1,2 +1,2 @@
app_metrics:
- resource: '@ArtprimaPrometheusMetricsBundle/Resources/config/routing.xml'
+ resource: '@ArtprimaPrometheusMetricsBundle/Resources/config/routing.yaml' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Recipe: artprima/prometheus-metrics-bundle to add support of v1.21