Skip to content

Add webpack config alias for leaflet.min.css#1525

Open
jonathan-stimactiv wants to merge 3 commits intosymfony:mainfrom
jonathan-stimactiv:patch-1
Open

Add webpack config alias for leaflet.min.css#1525
jonathan-stimactiv wants to merge 3 commits intosymfony:mainfrom
jonathan-stimactiv:patch-1

Conversation

@jonathan-stimactiv
Copy link
Copy Markdown

Q A
License MIT
Doc issue/PR #1524

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 25, 2026 10:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1525/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1525/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'symfony/ux-leaflet-map:^2.19'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copy link
Copy Markdown
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! However I'm not sure if you should create a new recipe version or not cc @nicolas-grekas

auto-merge was automatically disabled March 25, 2026 15:54

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 25, 2026 15:55
nicolas-grekas
nicolas-grekas previously approved these changes Mar 31, 2026
Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose v2.19 supports this

@Kocal
Copy link
Copy Markdown
Member

Kocal commented Mar 31, 2026

"add-lines": [
{
"file": "webpack.config.js",
"content": "\n .addAliases({'leaflet/dist/leaflet.min.css': 'leaflet/dist/leaflet.css'})",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just please convert this into an array, as done in 266f98b?

auto-merge was automatically disabled April 2, 2026 07:56

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) April 2, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants