Merge branch '4.4'

* 4.4:
  some backports from master
  Add return types to internal|final|private methods
  [HttpFoundation] Precalculate session expiry timestamp

Author: nicolas-grekas

Authorization/TraceableAccessDecisionManager.php

@@ -48,7 +48,7 @@ public function __construct(AccessDecisionManagerInterface $manager)
     /**
      * {@inheritdoc}
      */
-    public function decide(TokenInterface $token, array $attributes, $object = null)
+    public function decide(TokenInterface $token, array $attributes, $object = null): bool
     {
         $currentDecisionLog = [
             'attributes' => $attributes,
@@ -86,7 +86,7 @@ public function addVoterVote(VoterInterface $voter, array $attributes, int $vote
     /**
      * @return string
      */
-    public function getStrategy()
+    public function getStrategy(): string
     {
         // The $strategy property is misleading because it stores the name of its
         // method (e.g. 'decideAffirmative') instead of the original strategy name
@@ -97,15 +97,15 @@ public function getStrategy()
     /**
      * @return iterable|VoterInterface[]
      */
-    public function getVoters()
+    public function getVoters(): iterable
     {
         return $this->voters;
     }
 
     /**
      * @return array
      */
-    public function getDecisionLog()
+    public function getDecisionLog(): array
     {
         return $this->decisionLog;
     }

User/MissingUserProvider.php

@@ -32,23 +32,23 @@ public function __construct(string $firewall)
     /**
      * {@inheritdoc}
      */
-    public function loadUserByUsername(string $username)
+    public function loadUserByUsername(string $username): UserInterface
     {
         throw new \BadMethodCallException();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function refreshUser(UserInterface $user)
+    public function refreshUser(UserInterface $user): UserInterface
     {
         throw new \BadMethodCallException();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsClass(string $class)
+    public function supportsClass(string $class): bool
     {
         throw new \BadMethodCallException();
     }