Skip to content

Conversation

javiereguiluz
Copy link
Member

Documents symfony/symfony#21035 but there are some things I'm not sure about. Please, review.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all changes except the form theming, which I commented on. Did you have more things you were unsure about?

@wouterj wouterj removed the On hold label Apr 6, 2019
@javiereguiluz javiereguiluz changed the title (WIP) Documented the deprecation of the Templating component Documented the deprecation of the Templating component Apr 8, 2019
@javiereguiluz
Copy link
Member Author

Now that symfony/symfony#30959 has been merged, this is now ready for the final review.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants