[Workflow] remove unknown Twig function #11268
Conversation
documented twig function "workflow_build_transition_blocker_list" is neither implemented in the 4.2 nor the master branch of symfony/symfony
|
Hey @cawolf, thank you for your first contribution to the Symfony Docs! 🎉 It looks like you are right, that this Twig function is not included in Symfony. You can find some more information in symfony/symfony#26689 But this paragraph is about "accessing the blocker message", so removing the whole part and output the transitions name seems not correct. @lyrixx can you propose a replacement, I am not so deep into this component. Thank you. |
|
Yes, the function is more likely to be added in core than be removed here. We'll discuss it tomorrow with @lyrixx to make a final decision about this. |
javiereguiluz
added
the
⭐️ EU-FOSSA Hackathon
|
Ping @HeahDude. Please, don't forget to discuss about this. Thanks! |
|
Hello, I will be added in SF 4.3, PR in progress |
…ction (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Added workflow_transition_blockers twig function | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#11268 | License | MIT | Doc PR | symfony/symfony-docs#11268 EUFOSSA --- also related to #26689 I'm not a big fan of the current name. What should I pick? cc @javiereguiluz Commits ------- a2f9975 [Workflow] Added workflow_transition_blockers twig function
|
Thank you guys, appreciate the solution. |
|
@cawolf, thank you for creating this PR and testing our code examples! Please note that the function is now called |
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #11375). Discussion ---------- [Workflow] rename Twig function Hey everyone, this PR updates the Twig function name to the one which was introduced with symfony/symfony#30908 (relates to #11268) Commits ------- 930224a fix name of Twig function
8 participants
documented Twig function "workflow_build_transition_blocker_list" is neither implemented in the 4.2 nor the master branch of symfony/symfony and should therefore not be mentioned in the documentation example