Alias Monolog\Formatter\JsonFormatter instead of creating a new one #11301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we remove the whole service instead and use |
|
This solution leverage autowiring which can be "cool" to showcase in the doc. |
|
I updated base branch to 3.4 |
OskarStark
added
the
⭐️ EU-FOSSA Hackathon
|
We need some Monolog expert to review this. Thanks! |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jul 10, 2019
…creating a new one (B-Galati) This PR was merged into the 3.4 branch. Discussion ---------- Alias Monolog\Formatter\JsonFormatter instead of creating a new one Let me know if I am wrong but I thought it would be more reliable to use MonologBundle service instead of creating a new one. Commits ------- aecac40 Alias Monolog\Formatter\JsonFormatter instead of creating a new one
|
@B-Galati thanks for this contribution. However, while merging, we did some changes to finally remove the service and use the built-in Monolog service instead in the configuration. Both Christian and Grégoire expressed some concerns, so I think it's OK to do that. Thanks. |
|
@javiereguiluz Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if I am wrong but I thought it would be more reliable to use MonologBundle service instead of creating a new one.