[Workflow] Removed note about flushing in entered event
#12413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sentence is confusing and lead to bad practices: * It's not a good idea to flush in the model layer * It can lead to many calls to `flush()` method if the user uses a workflow (with many `to` places after a transition) * It's not possible to "preview" what a transition do, because everything is flushed in the DB
|
Thanks Grégoire. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 3, 2019
…t (lyrixx) This PR was merged into the 3.4 branch. Discussion ---------- [Workflow] Removed note about flushing in `entered` event This sentence is confusing and lead to bad practices: * It's not a good idea to flush in the model layer * It can lead to many calls to `flush()` method if the user uses a workflow (with many `to` places after a transition) * It's not possible to "preview" what a transition do, because everything is flushed in the DB Commits ------- d7511a1 [Workflow] Removed note about flushing in `entered` event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sentence is confusing and lead to bad practices:
flush()method if the user uses a workflow (with manytoplaces after a transition)