Skip to content

[Validator] Made the code sample more explicit with accepted values #13990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2020
Merged

[Validator] Made the code sample more explicit with accepted values #13990

merged 1 commit into from
Aug 3, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jul 23, 2020 •
edited
Loading

I'm not sure, I did not tested it, but it looks like the previous code sample was wrong

@lyrixx lyrixx requested review from HeahDude and xabbuh as code owners July 23, 2020 13:56
xabbuh
xabbuh approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xabbuh xabbuh added this to the 3.4 milestone Aug 3, 2020
@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2020

Thank you Grégoire.

@xabbuh xabbuh merged commit 351c645 into symfony:3.4 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @xabbuh @carsonbot