[DependencyInjection] 6.0 [autowiring] remove mention to @required #17654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrYamous
approved these changes
Jan 5, 2023
xabbuh
approved these changes
Jan 6, 2023
carsonbot
changed the title
|
Thank you Alexis. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 7, 2023
…on of `@required` in service_container (alexislefebvre) This PR was merged into the 6.0 branch. Discussion ---------- [DependencyInjection] 6.0 [injection_types] remove mention of `@required` in service_container Same logic than in #17654: Symfony 6+ requires PHP 8, so `#[Required]` can be used in all cases, and mentioning ``@required`` doesn't add any value. Commits ------- 76c0424 remove mention to required in service_container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 6+ requires PHP 8, so
#[Required]can be used in all cases, and mentioning@requireddoesn't add any value.